Do not load Card 'translations' relation by default

Author: amcsi

app/Console/Commands/BuildLackeyCommand.php

@@ -105,7 +105,7 @@ public function buildVariant(LackeyVariant $lackeyVariant)
             },
         ];
         $writer->insertOne(array_keys($definitions));
-        Card::with('set')->chunk(1000, function ($cards) use ($writer, $definitions) {
+        Card::with(['set', 'translations'])->chunk(1000, function ($cards) use ($writer, $definitions) {
             $writer->insertAll(
                 $cards
                     // Exclude ones not fully translated.

app/Http/Controllers/CardController.php

@@ -41,7 +41,7 @@ public function show(Card $card)
     private function getRelations(): array
     {
         $locale = \App::getLocale();
-        $relations = ['set'];
+        $relations = ['set', 'translations'];
         if ($locale !== Locale::JAPANESE) {
             $relations[] = 'suggestions';
         }

app/I18n/ManualTranslation/SuggestionApprover.php

@@ -21,6 +21,8 @@ public function approve(Suggestion $suggestion): void
         $attributes = $suggestion->only($keyAttributes);
         $values = $suggestion->attributesToArray();
 
+        $suggestion->loadMissing('card.translations');
+
         $cardAutoTranslation = $suggestion->card->getTranslation("$locale-auto");
         $newTranslationData = $cardAutoTranslation->replicate()->toArray();
 

app/Models/Card.php

@@ -97,8 +97,6 @@ class Card extends Model
         'ability_description',
     ];
 
-    protected $with = ['translations'];
-
     protected $dateFormat = 'Y-m-d H:i:s.u';
 
     protected $keyType = 'string';