Python packaging should not call compileall on the install folder since it is likely installed as root

[jay-sridharan]

This line here calls python3 -m compileall <my_package_install_dir> but this is usually inside a system folder and is installed using root.

This causes permission errors during packaging. The compileall should only happen if the install target is called, because the install command is usually executed like

sudo cmake --install <build_dir>

because it needs root permissions anyway to do the install. But packaging should be able to happen without needing to write to any root-owned folders, which is what the compileall module is trying to do.

ament_cmake/ament_cmake_python/cmake/ament_python_install_package.cmake

Line 198 in b681e59

\"${CMAKE_INSTALL_PREFIX}/${ARG_DESTINATION}/${package_name}\"

[jay-sridharan]

I believe this entire section can be deleted from the ament_cmake_install_package.cmake file.

  if(NOT ARG_SKIP_COMPILE)
    get_executable_path(python_interpreter_config Python3::Interpreter CONFIGURE)
    # compile Python files
    install(CODE
      "execute_process(
        COMMAND
        \"${python_interpreter_config}\" \"-m\" \"compileall\"
        \"${CMAKE_INSTALL_PREFIX}/${ARG_DESTINATION}/${package_name}\"
      )"
    )
  endif()