Vendor package requires `sudo`

[roncapat]

ament_cobra/cobra_vendor/CMakeLists.txt

Line 27 in 6a95e56

${CMAKE_COMMAND} -E chdir <SOURCE_DIR>/src sudo make install MAN=<SOURCE_DIR>/src_app LDFLAGS=-Wl,c.ar\ -pthread && ${CMAKE_COMMAND} -E chdir <SOURCE_DIR>/src_app sudo make install LDFLAGS=-Wl,c.ar\ -pthread

... however, common ROS 2 practice for vendor packages is to install everything in the workspace install folder and not touch system-wide folders.

For example, I should not see the vendor package trying to write /usr/local/bin/cobra.

I think BINDIR should be defined for make to put the cobra executable in the install folder of the workspace.

[fujitatomoya]

@mjcarroll can you assign yourself? (i do not have permission.)

[mjcarroll]

As I recall, the largest user of this package would be someone from the Space-ROS organization.

Perhaps @Bckempa or @ivanperez-keera can give some feedback here?

Personally, I would not expect a vendor package to require sudo, so removing that would be a reasonable adjustment.

[Bckempa]

Thanks for the tag-in, @mjcarroll.

Totally agree on ROS packages not adding files outside the workspace, we'd even prefer more isolation from the system if we could get it instead of relying on rosdep, but I digress.

From the Space ROS perspective, I don't think it matters if the README just states that you are required to have cobra installed from upstream but to match the other packages in the Ament org that provide external libraries like uncrustify and google_benchmark it seems like this should be set to use ${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}_install as an install prefix, even if it requires patching the upstream build.

There was a fairly major reworking of the relevant makefiles 6 months ago and it should be much easier to write a reasonable install line now. I've put this on the agenda for the next Space ROS technical meeting to see if anyone has the bandwidth to contribute a patch but we're gearing up for a quarterly release so it might be a month until a Space ROS volunteer has time.