misc: Throw user error for reduce function limitation (facebookincubator#12650)

Summary: Pull Request resolved: facebookincubator#12650

Reviewed By: Yuhta

Differential Revision: D71208389

Author: amitkdutta

velox/functions/prestosql/Reduce.cpp

@@ -38,11 +38,11 @@ void checkArraySizes(
     }
     const auto size = rawSizes[indices[row]];
     // We do not want this error to be suppressed by TRY(), so we simply throw.
-    VELOX_CHECK_LT(
-        size,
-        maxArraySize,
-        "reduce lambda function doesn't support arrays with more than {} elements",
-        maxArraySize);
+    if (size >= maxArraySize) {
+      VELOX_UNSUPPORTED(
+          "Reduce lambda function doesn't support arrays with more than {} elements",
+          maxArraySize);
+    }
   });
 }
 

velox/functions/prestosql/tests/ReduceTest.cpp

@@ -273,9 +273,9 @@ TEST_F(ReduceTest, limit) {
   auto data = makeRowVector({makeArrayVector(
       {0, 1'000, 10'000, 120'000, 120'010}, makeConstant(123, 1'000'000))});
 
-  VELOX_ASSERT_THROW(
+  VELOX_ASSERT_UNSUPPORTED_THROW(
       evaluate("reduce(c0, 0, (s, x) -> s + x, s -> 1 * s)", data),
-      "reduce lambda function doesn't support arrays with more than");
+      "Reduce lambda function doesn't support arrays with more than 100000 elements");
 
   // Exclude huge arrays (at rows 2 and 4).
   SelectivityVector rows(4);
@@ -288,9 +288,9 @@ TEST_F(ReduceTest, limit) {
   assertEqualVectors(expected, result, rows);
 
   // TRY should not mask errors.
-  VELOX_ASSERT_THROW(
+  VELOX_ASSERT_UNSUPPORTED_THROW(
       evaluate("TRY(reduce(c0, 0, (s, x) -> s + x, s -> 1 * s))", data),
-      "reduce lambda function doesn't support arrays with more than");
+      "Reduce lambda function doesn't support arrays with more than 100000 elements");
 }
 
 TEST_F(ReduceTest, rewrites) {