misc: Throw unsupported type error for unregistered type. (facebookincubator#12629)

Summary:
Pull Request resolved: facebookincubator#12629

Throwing unsupported type error when unregistered type is found and fail on unsupported type is true. This helps to fail a presto query with user errors instead of generic errors, thus helping better classificaiton of user and system errors.

Reviewed By: Yuhta, kgpai, zation99

Differential Revision: D71096915

Author: amitkdutta

velox/common/base/tests/GTestUtils.h

@@ -52,6 +52,10 @@
   VELOX_ASSERT_THROW_IMPL(                                  \
       facebook::velox::VeloxUserError, _expression, _errorMessage)
 
+#define VELOX_ASSERT_UNSUPPORTED_THROW(_expression, _errorMessage) \
+  VELOX_ASSERT_THROW_IMPL(                                         \
+      facebook::velox::VeloxUserError, _expression, _errorMessage)
+
 #define VELOX_ASSERT_RUNTIME_THROW(_expression, _errorMessage) \
   VELOX_ASSERT_THROW_IMPL(                                     \
       facebook::velox::VeloxRuntimeError, _expression, _errorMessage)

velox/type/parser/ParserUtil.cpp

@@ -30,9 +30,8 @@ TypePtr typeFromString(
     upper = "DOUBLE";
   }
   auto inferredType = getType(upper, {});
-  if (failIfNotRegistered) {
-    VELOX_CHECK(
-        inferredType, "Failed to parse type [{}]. Type not registered.", type);
+  if (failIfNotRegistered == true && inferredType == nullptr) {
+    VELOX_UNSUPPORTED("Failed to parse type [{}]. Type not registered.", type);
   }
   return inferredType;
 }

velox/type/parser/tests/TypeParserTest.cpp

@@ -165,7 +165,7 @@ TEST_F(TypeParserTest, invalidType) {
   VELOX_ASSERT_THROW(parseType("x"), "Failed to parse type [x]");
 
   // Ensure this is not treated as a row type.
-  VELOX_ASSERT_THROW(
+  VELOX_ASSERT_UNSUPPORTED_THROW(
       parseType("rowxxx(a)"), "Failed to parse type [a]. Type not registered.");
 }
 
@@ -242,22 +242,22 @@ TEST_F(TypeParserTest, rowType) {
 
   ASSERT_EQ(*parseType("row(array(Json))"), *ROW({ARRAY(JSON())}));
 
-  VELOX_ASSERT_THROW(
+  VELOX_ASSERT_UNSUPPORTED_THROW(
       *parseType("row(col0 row(array(HyperLogLog)))"),
       "Failed to parse type [HyperLogLog]. Type not registered.");
 
   // Field type canonicalization.
   ASSERT_EQ(*parseType("row(col iNt)"), *ROW({"col"}, {INTEGER()}));
 
   // Can only have names within rows.
-  VELOX_ASSERT_THROW(
+  VELOX_ASSERT_UNSUPPORTED_THROW(
       parseType("asd bigint"),
       "Failed to parse type [asd bigint]. Type not registered.");
 }
 
 TEST_F(TypeParserTest, typesWithSpaces) {
   // Type is not registered.
-  VELOX_ASSERT_THROW(
+  VELOX_ASSERT_UNSUPPORTED_THROW(
       parseType("row(time time with time zone)"),
       "Failed to parse type [time with time zone]. Type not registered.");
 
@@ -293,7 +293,7 @@ TEST_F(TypeParserTest, typesWithSpaces) {
           {TIMESTAMP_WITH_TIME_ZONE(), DOUBLE()}));
 
   // quoted field name with invalid type with spaces.
-  VELOX_ASSERT_THROW(
+  VELOX_ASSERT_UNSUPPORTED_THROW(
       parseType(
           "row(\"timestamp with time zone\" timestamp timestamp with time zone)"),
       "Failed to parse type [timestamp timestamp with time zone]. Type not registered.");