Skip to content

Commit d522943

Browse files
committed
style: remove unnecessary appearance properties in CSS
- Cleaned up CSS by removing redundant appearance properties from various selectors. - Added a new SVG icon for loop functionality.
1 parent b59147c commit d522943

File tree

3 files changed

+44
-54
lines changed

3 files changed

+44
-54
lines changed

chrome/global/general.css

Lines changed: 18 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ window#places {
9999
color: #000 !important;
100100
border-inline-start: 1px solid #bfbfbf !important;
101101
box-shadow: inset 0 -1px #bfbfbf !important;
102-
appearance: none !important;
102+
103103
}
104104

105105
#placeContentColumns :is(treecol, treecolpicker):where(:hover) {
@@ -145,7 +145,7 @@ window#places {
145145
#sidebar-box:not([lwt-sidebar]) {
146146
--sidebar-background-color: light-dark(#f7f7f7, #3b3b3b) !important;
147147
--sidebar-text-color: light-dark(#000, #fff) !important;
148-
appearance: none !important;
148+
149149
}
150150

151151
#browser:not([style*="--sidebar-border-color"]) {
@@ -166,7 +166,7 @@ window#places {
166166

167167
.sidebar-panel:not([lwt-sidebar]) #sidebar-search-container > #search-box,
168168
.sidebar-panel:not([lwt-sidebar]) #viewButton {
169-
appearance: none !important;
169+
170170
background-color: light-dark(#fff, #2b2b2b) !important;
171171
color: inherit !important;
172172
border: 1px solid light-dark(#bfbfbf, #686868) !important;
@@ -216,7 +216,7 @@ window#places {
216216
--panel-separator-color: light-dark(rgb(0, 0, 0,0.1),rgba(255, 255, 255,0.1)) !important;
217217
--in-content-page-background: var(--fp-contextmenu-bgcolor) !important;
218218
}
219-
219+
220220
/* App Menu */
221221
.addon-banner-item,
222222
.panel-banner-item {
@@ -560,14 +560,7 @@ menuitem[checked="true"]>.menu-iconic-left,
560560
margin: 0 !important;
561561
}
562562

563-
/* Context Menu */
564-
menupopup:not(.PanelUI-subView),
565-
menupopup:not(.PanelUI-subView) menuitem,
566-
menupopup:not(.PanelUI-subView) menu,
567-
menupopup:not(.PanelUI-subView) menuseparator,
568-
panel:not(#PopupSearchAutoComplete) {
569-
appearance: none !important;
570-
}
563+
571564

572565
menupopup:not(.PanelUI-subView),
573566
panel[type="autocomplete-richlistbox"],
@@ -589,13 +582,7 @@ panelview,
589582

590583
}
591584

592-
/* make room for menu shadow */
593-
menupopup:not(.PanelUI-subView) {
594-
padding: 4px 12px 20px !important;
595-
margin: -6px -12px -16px !important;
596-
597-
}
598-
585+
599586
.panel-arrowcontent {
600587
margin: 0 !important;
601588
}
@@ -697,7 +684,13 @@ panel menuseparator,
697684
#PlacesToolbar menupopup[placespopup="true"] menuseparator::before {
698685
display: none !important;
699686
}
700-
687+
menupopup[needsgutter] {
688+
@media (-moz-platform: linux) or (-moz-platform: windows) {
689+
& > :is(menu, menuitem) > .menu-icon {
690+
display: none!important;
691+
}
692+
}
693+
}
701694
menupopup menu,
702695
menupopup menuitem,
703696
menupopup menucaption,
@@ -711,11 +704,11 @@ menupopup menucaption,
711704
min-height: calc(16px + (var(--fp-contextmenu-menuitem-padding-block) + var(--fp-contextmenu-menuitem-border-width)) * 2) !important;
712705

713706
}
714-
715-
:not(:not(menubar)>menu, #ContentSelectDropdown)>menupopup>menuitem:not(.menuitem-iconic, [type="checkbox"], [type="radio"], .in-menulist, .in-menulist menuitem, .unified-nav-current),
716-
:not(:not(menubar)>menu, #ContentSelectDropdown)>menupopup>menu:not(.menu-iconic, [type="checkbox"], [type="radio"], .in-menulist, .in-menulist menu, .unified-nav-current),
707+
:not(:not(menubar)>menu, #ContentSelectDropdown)>menupopup>menuitem:not(.menuitem-iconic, [type="radio"], .in-menulist, .in-menulist menuitem, .unified-nav-current),
708+
:not(:not(menubar)>menu, #ContentSelectDropdown)>menupopup>menu:not(.menu-iconic, [type="radio"], .in-menulist, .in-menulist menu, .unified-nav-current),
709+
:not(:not(menubar)>menu, #contentAreaContextMenu)>menupopup>menu:not(.menu-iconic, [type="radio"], .in-menulist, .in-menulist menu, .unified-nav-current),
717710
:not(:not(menubar)>menu, #ContentSelectDropdown)>menupopup>menucaption {
718-
padding-inline-start: calc(var(--fp-contextmenu-menuitem-padding-inline) + 16px + var(--fp-contextmenu-menuicon-margin-inline)) !important;
711+
padding-inline-start: calc(var(--fp-contextmenu-menuitem-padding-inline) + 16px + var(--fp-contextmenu-menuicon-margin-inline)) !important;
719712
}
720713

721714

@@ -763,8 +756,7 @@ menuitem:is(.menuitem-iconic:not([data-usercontextid]), [type="checkbox"], [type
763756
}
764757

765758
.menu-right,
766-
.menu-accel-container {
767-
appearance: none !important;
759+
.menu-accel-container {
768760
margin-inline-end: 0 !important;
769761
-moz-context-properties: fill;
770762
fill: currentColor !important;

chrome/icons/icons.css

Lines changed: 25 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -657,6 +657,26 @@ menupopup > menuitem:is([checked="true"], [selected="true"]) .menu-iconic-icon {
657657
> menu:not(
658658
.menu-iconic,
659659
[type="checkbox"],
660+
[type="radio"],
661+
.in-menulist,
662+
.in-menulist menu,
663+
.unified-nav-current
664+
),
665+
:not(:not(menubar) > menu, #contentAreaContextMenu)
666+
> menupopup
667+
> menuitem:not(
668+
.menuitem-iconic,
669+
670+
[type="radio"],
671+
.in-menulist,
672+
.in-menulist menuitem,
673+
.unified-nav-current
674+
),
675+
:not(:not(menubar) > menu, #contentAreaContextMenu)
676+
> menupopup
677+
> menu:not(
678+
.menu-iconic,
679+
660680
[type="radio"],
661681
.in-menulist,
662682
.in-menulist menu,
@@ -931,10 +951,12 @@ menuitem[id="placesContext_open:newprivatewindow"] {
931951
--menu-image: url("media-speed.svg");
932952
}
933953

954+
#context-media-loop {
955+
--menu-image: url("loop.svg");
956+
}
934957
#context-video-fullscreen {
935958
--menu-image: url("fullscreen.svg");
936959
}
937-
938960
#context-leave-dom-fullscreen,
939961
menuitem[contexttype="fullscreen"][label*="Exit"] {
940962
--menu-image: url("fullscreen-exit.svg");
@@ -1108,34 +1130,9 @@ menuitem[id="placesContext_new:separator"] {
11081130
height: 24px !important;
11091131
width: 24px !important;
11101132
}
1111-
1112-
:not(:not(menubar) > menu, #ContentSelectDropdown)
1113-
> menupopup
1114-
> menuitem:not(
1115-
.menuitem-iconic,
1116-
[type="checkbox"],
1117-
[type="radio"],
1118-
.in-menulist,
1119-
.in-menulist menuitem,
1120-
.unified-nav-current
1121-
),
1122-
:not(:not(menubar) > menu, #ContentSelectDropdown)
1123-
> menupopup
1124-
> menu:not(
1125-
.menu-iconic,
1126-
[type="checkbox"],
1127-
[type="radio"],
1128-
.in-menulist,
1129-
.in-menulist menu,
1130-
.unified-nav-current
1131-
),
1132-
:not(:not(menubar) > menu, #ContentSelectDropdown) > menupopup > menucaption {
1133-
padding-inline-start: calc(
1134-
var(--fp-contextmenu-menuitem-padding-inline) + 16px +
1135-
var(--fp-contextmenu-menuicon-margin-inline)
1136-
) !important;
1137-
}
1133+
11381134
/* new*/
11391135
#placesContext_paste,
11401136
#context-paste-no-formatting{
11411137
--menu-image: url("edit-paste.svg");
1138+
}

chrome/icons/loop.svg

Lines changed: 1 addition & 0 deletions
Loading

0 commit comments

Comments
 (0)