Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest commit does not compile #92

Open
kelunik opened this issue Jan 9, 2021 · 1 comment
Open

Latest commit does not compile #92

kelunik opened this issue Jan 9, 2021 · 1 comment

Comments

@kelunik
Copy link
Member

kelunik commented Jan 9, 2021

Error while compiling on Travis CI:

/home/travis/build/amphp/amp/php-uv/php_uv.c: In function ‘php_uv_zval_to_valid_poll_fd’:
/home/travis/build/amphp/amp/php-uv/php_uv.c:457:14: error: ‘php_sockets_le_socket_ptr’ undeclared (first use in this function)
   } else if (php_sockets_le_socket_ptr && (socket = (php_socket *) zend_fetch_r
              ^
/home/travis/build/amphp/amp/php-uv/php_uv.c:457:14: note: each undeclared identifier is reported only once for each function it appears in
/home/travis/build/amphp/amp/php-uv/php_uv.c:457:102: warning: implicit declaration of function ‘php_sockets_le_socket_ptr’ [-Wimplicit-function-declaration]
 t_ptr && (socket = (php_socket *) zend_fetch_resource_ex(ptr, NULL, php_sockets
                                                                     ^
/home/travis/build/amphp/amp/php-uv/php_uv.c: In function ‘php_uv_zval_to_fd’:
/home/travis/build/amphp/amp/php-uv/php_uv.c:487:14: error: ‘php_sockets_le_socket_ptr’ undeclared (first use in this function)
   } else if (php_sockets_le_socket_ptr && (socket = (php_socket *) zend_fetch_r
              ^
@kelunik
Copy link
Member Author

kelunik commented Jan 9, 2021

Works fine if ext-sockets isn't compiled in.

kelunik added a commit to amphp/amp that referenced this issue Jan 9, 2021
@kelunik
Avoid using latest php-uv
58c6fd8 
See amphp/ext-uv#92.
TheTechsTech added a commit to symplely/ext-uv that referenced this issue Mar 30, 2023
@TheTechsTech
release ready, reverted signatures, bug fixes, no pecl needed
3793357 
**In reference to:** amphp#106, amphp#107, amphp#94, amphp#98, amphp#93, amphp#92, amphp#86, amphp#84, amphp#82, amphp#64

- BC signature changes has been revert since some of the tests wasn't changed to match, and too far off original design.
- Using current **Libuv** version or systems installed one, not `pecl`, this setup is not reliant on the really slow `pecl` system for updated installations.

The whole `uv_queue_work()` will need to be re implemented, the core internal `TSRM.c` thread related `tsrm_***_interpreter_context` functions used in PHP 7.4 has been removed since PHP 8.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kelunik