Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhea 2.0.7 breaks typings #91

Open
serratus opened this issue Jan 24, 2022 · 1 comment
Open

rhea 2.0.7 breaks typings #91

serratus opened this issue Jan 24, 2022 · 1 comment

Comments

@serratus
Copy link

serratus commented Jan 24, 2022

Describe the bug
TS build error

lib/connection.ts:107:44 - error TS2312: An interface can only extend an object type or intersection of object types with statically known members.

107 export interface ConnectionOptions extends RheaConnectionOptions {

To Reproduce

git clone [email protected]:amqp/rhea-promise.git
cd rhea-promise
npm run tsc

Expected behavior
The tsc build to succeed

Package-version: 2.1.0
node.js version: 16.1.0
OS name and version: macOS Big Sur, 11.6.2

Additional context
When pinning the dependency to "rhea": "2.0.6", the build succeeds without problems.

It seems like this issue was introduced with the latest changes amqp/rhea#375 which should have been a breaking change, not a patch-release.

Workaround
For anyone who's running into this issue, I recommend pinning rhea to 2.0.6 until this is resolved

@grs
Copy link
Member

grs commented Jan 24, 2022

I've published 2.0.8 without this commit, and then republished as 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants