From 89561adef2a474a00cb272c0e85325f4ff9af615 Mon Sep 17 00:00:00 2001 From: David Kornel Date: Tue, 6 May 2025 12:06:22 +0200 Subject: [PATCH 1/3] Update github CI 1. Updated actions to latests version 2. Remove old nodejs 16 3. Added nodejs 22 and 23 --- .github/workflows/node.js.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index d8e8b92..c99f680 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -15,13 +15,12 @@ jobs: strategy: matrix: - node-version: [16.x, 18.x, 20.x, 21.x] + node-version: [18.x, 20.x, 21.x, 22.x, 23.x] # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ steps: - - uses: actions/checkout@v2 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - run: npm install From 1cfd4d271d255138b2437218843458a3dcff0938 Mon Sep 17 00:00:00 2001 From: David Kornel Date: Tue, 6 May 2025 12:16:23 +0200 Subject: [PATCH 2/3] fix --- .github/workflows/node.js.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index c99f680..1744503 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -25,3 +25,5 @@ jobs: node-version: ${{ matrix.node-version }} - run: npm install - run: npm test + env: + NODE_OPTIONS: "--no-experimental-strip-types" From 475db25d2ee1967febf270df004dd7a30e312166 Mon Sep 17 00:00:00 2001 From: David Kornel Date: Tue, 6 May 2025 13:54:04 +0200 Subject: [PATCH 3/3] Fix tests Signed-off-by: David Kornel --- .github/workflows/node.js.yml | 2 -- test/sasl.ts | 6 +++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 1744503..c99f680 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -25,5 +25,3 @@ jobs: node-version: ${{ matrix.node-version }} - run: npm install - run: npm test - env: - NODE_OPTIONS: "--no-experimental-strip-types" diff --git a/test/sasl.ts b/test/sasl.ts index a6f4a09..361375e 100644 --- a/test/sasl.ts +++ b/test/sasl.ts @@ -227,7 +227,7 @@ describe('user-provided sasl mechanism', function () { }, step: function () { stepCalled = true; - this.outcome = true; + this.outcome = true as any; return; } }; @@ -260,7 +260,7 @@ describe('user-provided sasl mechanism', function () { }, step: function () { stepCalled = true; - this.outcome = false; + this.outcome = false as any; return; } }; @@ -300,7 +300,7 @@ describe('user-provided sasl mechanism', function () { return new Promise(resolve => { process.nextTick(() => { stepCalled = true; - this.outcome = true; + this.outcome = true as any; resolve(); }); });