Skip to content

fix: allow parsing of custom script outputs #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow parsing of custom script outputs #115

wants to merge 1 commit into from

Conversation

@daniel-statsig
Copy link

@daniel-statsig daniel-statsig commented May 8, 2024 •
edited
Loading

Description

with:
  script: "npm run my-script"

is resulting in an output that starts with some preamble before the JSON array is printed.

This preamble is resulting in the JSON.parse failing.

Example

> [email protected] size /path/to/repo
> size-limit "--json"

[
  {
    "name": "bundle-one",
    "passed": true,
    "size": 9319,
    "sizeLimit": 10000,
    "running": 0.23261666666666667,
    "loading": 0.18201171875
  },
  {
    "name": "bundle-two",
    "passed": true,
    "size": 11037,
    "sizeLimit": 12000,
    "running": 0.26038333333333336,
    "loading": 0.21556640625
  },
  {
    "name": "bundle-three",
    "passed": true,
    "size": 29620,
    "sizeLimit": 35000,
    "running": 0.25188333333333335,
    "loading": 0.578515625
  }
]

Fix

By finding the first '[' and last ']', we ensure we only try parse the JSON array part of the string

@daniel-statsig daniel-statsig changed the title fix issue with result parsing fix: allow parsing of custom script outputs May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@daniel-statsig