Minor doc update, minor error handling fixes (#40)

Co-authored-by: Andrew Schenck <[email protected]>

Author: andrewschenck

README.md

@@ -24,7 +24,7 @@ authentication handlers which can handle either use case, and more.
 
 
 ## Installing paramiko-jump
-Paramiko-jump is now available on PyPI, so you can readily install it with pip:
+Paramiko-jump is available on PyPI, so you can readily install it with pip:
 
 ```bash
 pip install paramiko-jump

paramiko_jump/client.py

@@ -50,7 +50,7 @@ def __init__(
 
         j = self._jump_session = jump_session
         if j is not None and not hasattr(j, '_transport'):
-            raise TypeError(f'bad jump_session: {j}')
+            raise ValueError(f'bad jump_session: {j}')
         self._auth_handler = auth_handler
 
     def __repr__(self):
@@ -130,6 +130,8 @@ def connect(
                 raise ValueError('jump_session= and sock= are mutually '
                                  'exclusive')
             transport = self._jump_session._transport
+            if not hasattr(transport, 'open_channel'):
+                raise ValueError('jump_session must be connected')
             sock = transport.open_channel(
                 kind='direct-tcpip',
                 dest_addr=(hostname, port),

paramiko_jump/handler.py

@@ -56,13 +56,13 @@ def simple_auth_handler(
     """
     answers = []
     if title:
-        _LOG.info(title)
+        print(title)
     if instructions:
-        _LOG.info(instructions)
+        print(instructions)
 
     for prompt, show_input in prompt_list:
         input_ = input if show_input else getpass
-        answers.append(input_(prompt))  # type: ignore
+        answers.append(input_(prompt))  # type: ignore[operator]
     return answers
 
 

tests/unit/test_client.py

@@ -31,6 +31,17 @@ def test_connect_failure(self, mock_connect):
             client.connect(hostname='invalid-host', username='username')
         self.assertEqual(str(context.exception), "Connection failed")
 
+    def test_invalid_jump_session_no_transport(self):
+        # Create a mock jump session without a _transport attribute
+        invalid_jump_session = MagicMock()
+        del invalid_jump_session._transport.open_channel
+
+        # Ensure that initializing SSHJumpClient with this invalid jump session raises a TypeError
+        with self.assertRaises(ValueError) as context:
+            client = SSHJumpClient(jump_session=invalid_jump_session)
+            client.connect(hostname='invalid-host', username='username')
+        # self.assertEqual(str(context.exception), f'bad jump_session')
+
     @patch('paramiko_jump.client.SSHJumpClient.exec_command')
     def test_exec_command_failure(self, mock_exec_command):
         mock_exec_command.side_effect = Exception("Command failed")
@@ -145,7 +156,7 @@ def test_connect_with_jump_session(self, mock_connect):
         jump_client._transport.open_channel.assert_called()
 
     def test_invalid_jump_session(self):
-        with self.assertRaises(TypeError):
+        with self.assertRaises(ValueError):
             SSHJumpClient(jump_session="invalid_session")
 
     @patch('paramiko_jump.client.SSHClient.connect')