Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script blindly assumes packages will be installed #505

Open
ballo opened this issue May 5, 2024 · 1 comment
Open

script blindly assumes packages will be installed #505

ballo opened this issue May 5, 2024 · 1 comment

Comments

@ballo
Copy link

ballo commented May 5, 2024

This script fails a lot because it just runs things blindly without checking if there was success or failure. It's just a poorly written hack.

The script should first prompt a user whether to attempt to install the necessary packages. It should then, separately, confirm the necessary packages are installed before asking for configuration settings like IPs etc. I think this was a hack that only worked for one machine (probably based on some blog post brain fart) which was then haphazardly expanded to support some other distros without anyone considering how to write a proper program. I mean once you have either a working or non-working installation (which it is who the heck knows), the only way to proceed from there is to delete packages whether the user wants the packages deleted or not. It's all very odd, but I suppose this is the UNIX way for better or worse.

@mleku
Copy link

mleku commented May 6, 2024

it works perfectly on ubuntu, probably what you need is to port it to cover whichever distribution you want it to cover specifically, i'm not sure what that could be because you haven't said what the case was with your installation failure, what distro, version, etc, i'm sure that contributing fixes that help for your case would be help others too

this script is a godsend for me... it's never been easier to make VPN tunnels and what are basically VLANs as with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants