Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$location.hash() parsing not working with Okta #143

Open
jayhartley opened this issue Nov 4, 2016 · 0 comments
Open

$location.hash() parsing not working with Okta #143

jayhartley opened this issue Nov 4, 2016 · 0 comments

Comments

@jayhartley
Copy link

jayhartley commented Nov 4, 2016

I've been using oauth-ng with an early release of Okta's Open ID Connect support. For whatever reason, their fragment on redirect (Implicit flow) starts with a forward slash. (e.g. https:// myserver.com/myOnePageApp.html#/access_token=eyJ...&id_token=eyJ...)

All I had to do to make it work was a small change to the regex in AccessToken. I've attached a patch file with the fix and some unit tests:
support_okta.patch.txt

You'll note I also had to make a couple of changes to the package.json. Updated the grunt-contrib-imagemin and karma-phantomjs-launcher versions to the latest. Those were required to get npm install and karma testing, respectively, to work on my Mac (OSX 10.11). They are not necessarily required for the patch, but I thought I'd bring them to your attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant