Add quantity level to carrier #1391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for putting in the effort, but without knowing this domain it seems to me maybe this quantity falls short on our criteria list: https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit#great-but-before-you-start In short, I'm not convinced it adds enough value for enough people to justify increasing the binary size for everyone. I think it's better to add this quantity per application for now, until UnitsNet maybe gets a way to offer quantities in individual nugets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Level To Carrier with unit dBc is widely used in telecommunications and signal processing. Although, the calucalation formula is simular to Level/dB, it is used and treated as an own quantity.
For more information see https://en.wikipedia.org/wiki/DBc