-
Notifications
You must be signed in to change notification settings - Fork 390
Introduce an ASP.NET project to the Sample projects #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, sure! |
@angularsen Full disclosure, I work with @mindball and pitched him the idea as a Do you think we want this in |
I'm living in the v6 world, it's 2025, what is this v5 you guys keep
talking about? 😂
Seriously though, as soon as your base units and possibly the fractions PR
has landed, we should be nearing a release or at least beta/stabilization,
and should merge into master and make a maintenance release/v5 branch.
|
It usually takes me at least 3-4 months to adjust... |
Great, I'm on it |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This issue was automatically closed due to inactivity. |
I noticed this issue was closed due to inactivity, but I’ve been working on this topic in my public repository: ASP.Net.UnitsNetSerializationExamples. I’ve been progressing on this in my spare time over weekends, which is why it took longer. However, I’m close to finishing and will have it ready as soon as possible. |
No problem, no rush on our end, so just take your time 😃 |
Hello Angularsen, I want to inform you that I have finished the example of serialization for both converters and have provided a detailed description ASP.Net.UnitsNetSerializationExamples. I remain available if you have any questions. |
@mindball Hey that's great! We can add a link to it in the README. A couple of first impressions:
Not sure if this is a codespace thing, I didn't try checking it out locally on my machine. |
These refactorings @mindball come thanks to @lipchev (who is currently working hard on SerializerType.SystemTextJson ). I just want to explain how the project should be launched and if I find free time I will add screenshots with explanation:
Regarding your comment on missing examples early in the README—I appreciate your feedback! I'm not entirely sure what specific examples you would find most useful. I'd be happy to refine the documentation further if you could clarify your expectations 😊. |
Great! My suggestions:
|
Motivation:
I've been looking at the different serialization options available on the documentation page and was wondering if you would be interested in a sample project that demonstrates their usages in ASP.NET.
As there is currently no support for the
System.Text
converter, that is the default for the minimal-api style project, I was thinking of starting with a basic Controllers API, which we would hopefully extend in the future.In terms of methods, I was thinking of an API similar to the UnitConverter or maybe a "calculator-type" thing that uses one of the standard operations.
In addition, at work, we've been using some extensions that provide the necessary OpenAPI metadata, such that the API is nicely formatted in Swagger, that can also be added later.
The text was updated successfully, but these errors were encountered: