Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type for setUsername #394

Open
1 of 3 tasks
nigelsim opened this issue Sep 11, 2020 · 0 comments
Open
1 of 3 tasks

Wrong type for setUsername #394

nigelsim opened this issue Sep 11, 2020 · 0 comments

Comments

@nigelsim
Copy link

For support questions, please consider using Gitter - Chat

I'm submitting a ...

  • bug report

  • feature request

  • question about the decisions made in the repository

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

The Angulartics2 service has a replay subject, setUsername that takes the type { userId: string | number } | string. However, none of the providers accept this type. They all accept only string.

  • What is the expected behavior?

Types to match

  • What is the motivation / use case for changing the behavior?

Invalid user identifiers have been sent through to MixPanel.

  • Environment:

please run the following and copy the output

Angular CLI: 9.1.9
Node: 10.19.0
OS: linux x64

Angular: 9.1.11
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, upgrade
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.25
@angular-devkit/build-angular     0.803.25
@angular-devkit/build-optimizer   0.803.25
@angular-devkit/build-webpack     0.803.25
@angular-devkit/core              8.3.25
@angular-devkit/schematics        9.1.9
@angular/cli                      9.1.9
@ngtools/webpack                  8.3.25
@schematics/angular               9.1.9
@schematics/update                0.901.9
rxjs                              6.6.2
typescript                        3.9.7
webpack                           4.43.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant