Skip to content

hw masp auto test #3890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 25, 2025
Merged

hw masp auto test #3890

merged 5 commits into from
Feb 25, 2025

Conversation

tzemanovic
Copy link
Member

Describe your changes

Adds a device automation for MASP e2e test to run in the CI.

Depends-On: #3797

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 4, 2024 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 ⛓️ Depends-On Requirements

Wonderful, this rule succeeded.

Requirement based on the presence of Depends-On in the body of the pull request

@brentstone
Copy link
Collaborator

@tzemanovic is this PR still needed?

@tzemanovic
Copy link
Member Author

@tzemanovic is this PR still needed?

yeah, we should update it once we have masp support in ledger app rdy

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 7, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 ⛓️ Depends-On Requirements

Wonderful, this rule succeeded.

Requirement based on the presence of Depends-On in the body of the pull request

@murisi murisi force-pushed the tomas/hw-masp-auto-test branch from 054614e to 45878c7 Compare February 17, 2025 05:31
@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.52%. Comparing base (94d3a8e) to head (b5f4a7d).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3890      +/-   ##
==========================================
- Coverage   74.52%   74.52%   -0.01%     
==========================================
  Files         339      339              
  Lines      110504   110504              
==========================================
- Hits        82358    82351       -7     
- Misses      28146    28153       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murisi murisi force-pushed the tomas/hw-masp-auto-test branch from 45878c7 to 874e878 Compare February 24, 2025 19:10
@murisi murisi requested review from Fraccaman and murisi February 24, 2025 19:16
@tzemanovic tzemanovic added testing backport-libs-0.149 Backport libraries to 0.149 maintenance branch labels Feb 25, 2025
murisi
murisi approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@murisi murisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Feb 25, 2025
@mergify mergify bot merged commit 4924730 into main Feb 25, 2025
24 of 25 checks passed
@mergify mergify bot deleted the tomas/hw-masp-auto-test branch February 25, 2025 09:33
@mergify mergify bot mentioned this pull request Feb 25, 2025
Merged
3 tasks
mergify bot added a commit that referenced this pull request Feb 25, 2025
@mergify
Merge pull request #4411 from anoma/mergify/bp/maint-libs-0.47/pr-3890
a3ec2f9 
hw masp auto test (backport #3890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murisi murisi murisi approved these changes

@Fraccaman Fraccaman Awaiting requested review from Fraccaman

Assignees
No one assigned
Labels
backport-libs-0.149 Backport libraries to 0.149 maintenance branch merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzemanovic @brentstone @murisi