impedance: Account for "failed to generate" errors as well.

Author: anse1

Diff for: impedance.cc

@@ -8,6 +8,7 @@ static map<const char*, long> occurances_in_failed_query;
 static map<const char*, long> occurances_in_ok_query;
 static map<const char*, long> retries;
 static map<const char*, long> limited;
+static map<const char*, long> failed;
 
 impedance_visitor::impedance_visitor(map<const char*, long> &occured)
   :   _occured(occured)
@@ -74,6 +75,7 @@ void report(std::ostream &out)
 	<< "\"bad\": " << pair->second << ", "
 	<< "\"ok\": " << occurances_in_ok_query[pair->first] << ", "
 	<< "\"limited\": " << limited[pair->first] << ", "
+	<< "\"failed\": " << failed[pair->first] << ", "
 	<< "\"retries\": " << retries[pair->first] << "} ";
 
     if (next(pair) != occurances_in_failed_query.end())
@@ -92,4 +94,9 @@ void limit(const char *p)
   limited[p]++;
 }
 
+void fail(const char *p)
+{
+  failed[p]++;
+}
+
 }

Diff for: impedance.hh

@@ -36,6 +36,9 @@ namespace impedance {
   void limit(const char *p);
   inline void limit(const std::type_info &id) { return limit(id.name()); }
   inline void limit(prod *p) { return limit(typeid(*p)); }
+  void fail(const char *p);
+  inline void fail(const std::type_info &id) { return fail(id.name()); }
+  inline void fail(prod *p) { return fail(typeid(*p)); }
   void report();
   void report(std::ostream &out);
 }

Diff for: log.sql

@@ -115,9 +115,9 @@ create index on error(t);
 
 create view impedance as
     select id, generated, level, nodes, updated,
-    	   prod, ok, bad, js.retries, limited
+    	   prod, ok, bad, js.retries, limited, failed
     from stat, jsonb_to_recordset(impedance->'impedance')
-    	 js(prod text, ok int, bad int, retries int, limited int)
+    	 js(prod text, ok int, bad int, retries int, limited int, failed int)
     where impedance is not null;
 
 comment on view impedance is 'stat table with normalized jsonb';

Diff for: prod.cc

@@ -43,5 +43,6 @@ void prod::match()
 
 void prod::fail(const char *reason)
 {
+  impedance::fail(this);
   throw std::runtime_error(reason);
 }