eslint: Remove flowtype/generic-spacing lint.

This conflicts with our prettier config, and doesn't seem to be very
useful - we frequently needed to disable it. It was added in a1edcaa
without any explanation, but it seems to largely have been a copy of the
recommended config at the time.

See https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/fmt.2Ftest.20prettier.20mismatch/near/1326785

Author: WesleyAC

.eslintrc.yaml

@@ -316,7 +316,6 @@ rules:
   flowtype/boolean-style: [error, boolean]
   flowtype/define-flow-type: warn
   flowtype/delimiter-dangle: off
-  flowtype/generic-spacing: [error, never]
   flowtype/no-dupe-keys: error
   flowtype/no-primitive-constructor-types: error
   flowtype/no-types-missing-file-annotation: error

src/__flow-tests__/nav-test.js

@@ -9,8 +9,6 @@ import { createStackNavigator, type StackNavigationProp } from '@react-navigatio
 
 import { type RouteProp, type RouteParamsOf } from '../react-navigation';
 
-/* eslint-disable flowtype/generic-spacing */
-
 // Test that `RouteProp` gives route.params the right type.
 function testRouteParamTypes() {
   type ProfileProps = {|

src/api/realmDataTypes.js

@@ -11,7 +11,6 @@ import type { InitialDataRealm } from './initialDataTypes';
  * in the /register response (InitialDataRealm has lots of properties that
  * start with "realm_"). But we expect the values to be typed the same.
  */
-/* eslint-disable flowtype/generic-spacing */
 /* prettier-ignore */
 export type RealmDataForUpdate = $ReadOnly<{
   //

src/common/ZulipButton.js

@@ -65,7 +65,6 @@ const styles = createStyleSheet({
 });
 
 type Props = $ReadOnly<{|
-  /* eslint-disable flowtype/generic-spacing */
   style?: SubsetProperties<
     ViewStyle,
     {|

src/generics.js

@@ -3,8 +3,6 @@
  * Tools for manipulating generic types in the Flow type system.
  */
 
-/* eslint-disable flowtype/generic-spacing */
-
 /**
  * The type `S`, plus a check that `S` is a supertype of `T`.
  *

src/react-native-action-sheet.js

@@ -5,8 +5,6 @@ import { connectActionSheet as connectActionSheetInner } from '@expo/react-nativ
 
 import type { BoundedDiff } from './generics';
 
-/* eslint-disable flowtype/generic-spacing */
-
 export type ShowActionSheetWithOptions = (
   { options: string[], cancelButtonIndex: number, ... },
   (number) => void,

src/react-native-safe-area-context.js

@@ -7,8 +7,6 @@ import {
 
 import type { BoundedDiff } from './generics';
 
-/* eslint-disable flowtype/generic-spacing */
-
 /**
  * Exactly like `withSafeAreaInsets` upstream, but properly typed.
  *

src/react-navigation.js

@@ -14,8 +14,6 @@ import {
 
 import type { GlobalParamList } from './nav/globalTypes';
 
-/* eslint-disable flowtype/generic-spacing */
-
 /**
  * A type to use for the `route` prop on a screen component.
  *

src/react-redux.js

@@ -27,8 +27,6 @@ import type { BoundedDiff } from './generics';
 // eslint-disable-next-line no-restricted-imports
 export { Provider } from 'react-redux';
 
-/* eslint-disable flowtype/generic-spacing */
-
 // We leave this as invariant in `C` (i.e., we don't write `-C` or `+C`)
 // because Flow says `ElementConfig` is invariant.  (If you try writing
 // `OwnProps<-C, …` or `OwnProps<+C, …`, Flow gives an error saying the `C`

src/start/IosCompliantAppleAuthButton/index.js

@@ -13,7 +13,6 @@ import { getGlobalSettings } from '../../selectors';
 type Props = $ReadOnly<{|
   // See `ZulipButton`'s `style` prop, where a comment discusses this
   // idea.
-  /* eslint-disable flowtype/generic-spacing */
   style?: SubsetProperties<
     ViewStyle,
     {|

src/types.js

@@ -205,7 +205,6 @@ type OutboxBase = $ReadOnly<{|
   // It's used for sending the message to the server.
   markdownContent: string,
 
-  /* eslint-disable flowtype/generic-spacing */
   ...SubsetProperties<
     // Could use `MessageBase` here.  Then Flow would check that the listed
     // properties are in `MessageBase`, rather than just in both branches of