From 832b180e1c3dbcaee3eded9092732eaed29b93bb Mon Sep 17 00:00:00 2001 From: GomathiselviS Date: Tue, 14 May 2024 12:38:41 -0400 Subject: [PATCH] address review comments --- plugins/modules/ec2_vol.py | 12 +++++++++++ plugins/modules/ec2_vpc_igw_info.py | 10 ++++----- plugins/modules/ec2_vpc_subnet_info.py | 28 +++++++++++++------------- 3 files changed, 31 insertions(+), 19 deletions(-) diff --git a/plugins/modules/ec2_vol.py b/plugins/modules/ec2_vol.py index cca6a96e1d..d1000e0c43 100644 --- a/plugins/modules/ec2_vol.py +++ b/plugins/modules/ec2_vol.py @@ -230,6 +230,7 @@ - This was changed in version 2.0.0 from a dictionary to a list of dictionaries. type: list elements: dict + returned: when success sample: [{ "attach_time": "2015-10-23T00:22:29.000Z", "deleteOnTermination": "false", @@ -240,48 +241,59 @@ create_time: description: The time stamp when volume creation was initiated. type: str + returned: when success sample: "2015-10-21T14:36:08.870Z" encrypted: description: Indicates whether the volume is encrypted. type: bool + returned: when success sample: False id: description: The ID of the volume. type: str + returned: when success sample: "vol-35b333d9" iops: description: The number of I/O operations per second (IOPS) that the volume supports. type: int + returned: when success sample: null size: description: The size of the volume, in GiBs. type: int + returned: when success sample: 1 snapshot_id: description: The snapshot from which the volume was created, if applicable. type: str + returned: when success sample: "" status: description: The volume state. type: str + returned: when success sample: "in-use" tags: description: Any tags assigned to the volume. type: dict + returned: when success sample: { env: "dev" } type: description: The volume type. This can be gp2, io1, st1, sc1, or standard. type: str + returned: when success sample: "standard" zone: description: The Availability Zone of the volume. type: str + returned: when success sample: "us-east-1b" throughput: description: The throughput that the volume supports, in MiB/s. type: int + returned: when success sample: 131 """ diff --git a/plugins/modules/ec2_vpc_igw_info.py b/plugins/modules/ec2_vpc_igw_info.py index 583719c040..ac8681fc7d 100644 --- a/plugins/modules/ec2_vpc_igw_info.py +++ b/plugins/modules/ec2_vpc_igw_info.py @@ -75,27 +75,27 @@ contains: attachments: description: Any VPCs attached to the internet gateway. - returned: I(state=present) + returned: always type: complex contains: state: description: The current state of the attachment. - returned: I(state=present) + returned: always type: str sample: available vpc_id: description: The ID of the VPC. - returned: I(state=present) + returned: always type: str sample: vpc-02123b67 internet_gateway_id: description: The ID of the internet gateway. - returned: I(state=present) + returned: always type: str sample: igw-2123634d tags: description: Any tags assigned to the internet gateway. - returned: I(state=present) + returned: always type: dict sample: tags: diff --git a/plugins/modules/ec2_vpc_subnet_info.py b/plugins/modules/ec2_vpc_subnet_info.py index 8350cbbbb3..35be7c3838 100644 --- a/plugins/modules/ec2_vpc_subnet_info.py +++ b/plugins/modules/ec2_vpc_subnet_info.py @@ -78,62 +78,62 @@ contains: id: description: Subnet resource id - returned: I(state=present) + returned: always type: str sample: subnet-b883b2c4 cidr_block: description: The IPv4 CIDR of the Subnet - returned: I(state=present) + returned: always type: str sample: "10.0.0.0/16" ipv6_cidr_block: description: The IPv6 CIDR block actively associated with the Subnet - returned: I(state=present) + returned: always type: str sample: "2001:db8:0:102::/64" availability_zone: description: Availability zone of the Subnet - returned: I(state=present) + returned: always type: str sample: us-east-1a availability_zone_id: description: The AZ ID of the subnet. - returned: I(state=present) + returned: always type: str sample: use1-az6 state: description: state of the Subnet - returned: I(state=present) + returned: always type: str sample: available tags: description: tags attached to the Subnet, includes name - returned: I(state=present) + returned: always type: dict sample: {"Name": "My Subnet", "env": "staging"} map_public_ip_on_launch: description: whether public IP is auto-assigned to new instances - returned: I(state=present) + returned: always type: bool sample: false assign_ipv6_address_on_creation: description: whether IPv6 address is auto-assigned to new instances - returned: I(state=present) + returned: always type: bool sample: false vpc_id: description: the id of the VPC where this Subnet exists - returned: I(state=present) + returned: always type: str sample: vpc-67236184 available_ip_address_count: description: number of available IPv4 addresses - returned: I(state=present) + returned: always type: str sample: 251 default_for_az: description: indicates whether this is the default Subnet for this Availability Zone - returned: I(state=present) + returned: always type: bool sample: false enable_dns64: @@ -143,7 +143,7 @@ sample: false ipv6_association_id: description: The IPv6 association ID for the currently associated CIDR - returned: I(state=present) + returned: always type: str sample: subnet-cidr-assoc-b85c74d2 ipv6_native: @@ -152,7 +152,7 @@ sample: false ipv6_cidr_block_association_set: description: An array of IPv6 cidr block association set information. - returned: I(state=present) + returned: always type: complex contains: association_id: