Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring idea: rds_instance #1985

Open
1 task done
alinabuzachis opened this issue Feb 21, 2024 · 2 comments
Open
1 task done

Refactoring idea: rds_instance #1985

alinabuzachis opened this issue Feb 21, 2024 · 2 comments
Milestone

Comments

@alinabuzachis
Copy link
Collaborator

Summary

The rds_instance plugin, as it is currently written, is very difficult to understand and quite complex.
I propose to refactor it to make our code easier to understand, in particular:

  • Break each function down into smaller scoped functions.
  • Add documentation to each function to clarify what it does.
  • Ensure that each method has type hints so that it is clear what a given method returns.
  • Make sure we have unit tests that cover all the logic we are trying to apply.

Issue Type

Feature Idea

Component Name

rds_instance

Additional Information

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@tremble tremble added this to the 8.0.0 milestone Feb 21, 2024
@eRadical
Copy link
Contributor

Hi @alinabuzachis,

So glad you're tackling this.

Isn't this module sharing a lot w/ rds_cluster?

@eRadical
Copy link
Contributor

On another note - in rds_instance there is a mention of a future implementation of wait_timeout - is there any chance for it?

This is already avail in msk_cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants