Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable integration test for autoscaling_instance* modules #2383

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Re-enable integration test for autoscaling_instance* modules #2383

merged 5 commits into from
Nov 12, 2024
+5 −2

Conversation

GomathiselviS
Copy link
Collaborator

@GomathiselviS GomathiselviS commented Nov 6, 2024 •
edited by gravesm
Loading

SUMMARY

Fixes #2362

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@gravesm
Copy link
Member

gravesm commented Nov 7, 2024

recheck

@gravesm gravesm closed this Nov 7, 2024
@gravesm gravesm reopened this Nov 7, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as resolved.

Sign in to view
@GomathiselviS
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/393173f0a1424ad0aaf67446cbb77753

✔️ ansible-galaxy-importer SUCCESS in 5m 19s
✔️ build-ansible-collection SUCCESS in 10m 02s
✔️ ansible-test-splitter SUCCESS in 4m 16s
✔️ integration-amazon.aws-1 SUCCESS in 9m 15s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ff31f4fe3727490a870c01104d3017a0

✔️ ansible-galaxy-importer SUCCESS in 4m 47s
✔️ build-ansible-collection SUCCESS in 10m 45s
✔️ ansible-test-splitter SUCCESS in 3m 54s
✔️ integration-amazon.aws-1 SUCCESS in 10m 44s
Skipped 43 jobs

alinabuzachis
alinabuzachis approved these changes Nov 11, 2024
View reviewed changes
tests/integration/targets/autoscaling_instance/tasks/main.yml Outdated
@@ -2,6 +2,7 @@
# Beware: most of our tests here are run in parallel.
# To add new tests you'll need to add a new host to the inventory and a matching
# '{{ inventory_hostname }}'.yml file in roles/ec2_asg/tasks/
# testing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this, right?

@GomathiselviS GomathiselviS added the mergeit Merge the PR (SoftwareFactory) label Nov 11, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/718ed1abf91e4fb7989efd37715bfeff

✔️ ansible-galaxy-importer SUCCESS in 5m 19s
✔️ build-ansible-collection SUCCESS in 10m 11s
✔️ ansible-test-splitter SUCCESS in 3m 55s
❌ integration-amazon.aws-1 FAILURE in 14m 27s
Skipped 43 jobs

@GomathiselviS GomathiselviS removed the mergeit Merge the PR (SoftwareFactory) label Nov 11, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/578a316c34ed4e0b8b8c9bec59384b90

✔️ ansible-galaxy-importer SUCCESS in 5m 38s
✔️ build-ansible-collection SUCCESS in 10m 22s
✔️ ansible-test-splitter SUCCESS in 3m 46s
✔️ integration-amazon.aws-1 SUCCESS in 10m 58s
Skipped 43 jobs

@tremble tremble added mergeit Merge the PR (SoftwareFactory) backport-9 labels Nov 12, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/a26d7c60d13e467597a6c8f48b7b3200

✔️ ansible-galaxy-importer SUCCESS in 4m 48s
✔️ build-ansible-collection SUCCESS in 10m 11s
✔️ ansible-test-splitter SUCCESS in 3m 58s
✔️ integration-amazon.aws-1 SUCCESS in 11m 35s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 453e084 into ansible-collections:main Nov 12, 2024
46 of 47 checks passed
@patchback Patchback
Copy link

patchback bot commented Nov 12, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/453e0844fb51e34a32a95e78b78ed1279d68cfa8/pr-2383

Backported as #2389

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 12, 2024
@GomathiselviS @patchback
Re-enable integration test for autoscaling_instance* modules (#2383)
570f23a 
SUMMARY

Fixes #2362
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Mark Chappell
(cherry picked from commit 453e084)
@patchback patchback bot mentioned this pull request Nov 12, 2024
Merged
@tremble
Copy link
Contributor

tremble commented Nov 12, 2024

@GomathiselviS Thanks for the follow-up on this (including the gentle reminders on mattclay/aws-terminator#311)

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Nov 12, 2024
@patchback
Re-enable integration test for autoscaling_instance* modules (#2383) (#…
5edd9ea 
…2389)

This is a backport of PR #2383 as merged into main (453e084).
SUMMARY


Fixes #2362
ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@gravesm gravesm gravesm approved these changes

@tremble tremble tremble approved these changes

@hakbailey hakbailey Awaiting requested review from hakbailey

Assignees
No one assigned
Labels
backport-9 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable integration test for autoscaling_instance* modules
4 participants
@GomathiselviS @gravesm @tremble @alinabuzachis