add filter support for one_template module #9547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
nilsding
approved these changes
Jan 7, 2025
ansibullbot
removed
ci_verified
felixfontein
added
check-before-release
felixfontein
reviewed
Jan 7, 2025
ansibullbot
added
the
needs_revision
russoz
reviewed
Jan 8, 2025
felixfontein
reviewed
Jan 8, 2025
ansibullbot
removed
the
needs_revision
russoz
reviewed
Jan 10, 2025
russoz
reviewed
Jan 10, 2025
apply suggestion from code review add one_template filter changelog fragment rewrote filter flag to use string instead of int renamed flag to option in changelog added PR link to changelog fragment Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Alexei Znamensky <[email protected]>
|
I'll merge this in a few days if nobody objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #9278
As discussed in the issue a filter flag was added to the
one_templatemodule. The default behavior is preserved by setting thefilteroption to the default value of-3. Users can change the behavior by using values from-1to-4.Edit: filter option was changed to user friendly values (user, user_groups, ...) and internally the module converts those to the integers needed for the OpenNebula API.
The description of the module was also updated with an explanation of those values.
minor_changes:
filterflag for retrieving templates which are not owned by the user (one_template only returns templates owned by user but not by group membership #9278).ISSUE TYPE
COMPONENT NAME
one_template
ADDITIONAL INFORMATION
See #9278 for a reproduction playbook and expected outputs.