fix(postgresql_ext): Reconnect before upgrade (#689)

Some extensions like timescaledb need a fresh connection to be upgraded. See
https://docs.timescale.com/self-hosted/latest/upgrades/minor-upgrade/.

Signed-off-by: Julien Riou <[email protected]>

Author: Julien Riou

changelogs/fragments/689-reconnect-before-upgrade.yml

@@ -0,0 +1,3 @@
+bugfixes:
+  - postgresql_ext - Reconnect before upgrade to avoid accidental load of the upgraded extension
+    (https://github.com/ansible-collections/community.postgresql/pull/689).

plugins/modules/postgresql_ext.py

@@ -469,6 +469,11 @@ def main():
                     else:
                         valid_update_path = ext_valid_update_path(cursor, ext, curr_version, real_version)
                         if valid_update_path:
+                            # Reconnect (required by some extensions like timescaledb)
+                            if not module.check_mode:
+                                db_connection.close()
+                                db_connection, dummy = connect_to_db(module, conn_params, autocommit=True)
+                                cursor = db_connection.cursor(**pg_cursor_args)
                             changed = ext_update_version(module.check_mode, cursor, ext, version)
                         else:
                             if version == 'latest':