Wrong parameters for FEC required

[Planzo]

SUMMARY

os10_interface role is capable to set "fec" on interface ethernet ports, but it is only possible to set it to true or false.
This is not correct. Dells os10 knows at least the 4 different values as followed:

• CL74-FC — Supports 25G and 50G
• CL91-RS — Supports 100G
• CL108-RS — Supports 25G and 50G
• CL119-RS — Supports 400G
• off — Disables FEC

See documentation:
https://www.dell.com/support/manuals/de-de/dell-emc-smartfabric-os10/smartfabric-os-user-guide-10-5-2-6/forward-error-correction?guid=guid-b4d9bde5-0638-46a3-a8f7-f5d22c66dce2&lang=en-us

On my device it even shows more:

my-awesome-switch# configure terminal
my-awesome-switch(config)# interface ethernet1/1/48
my-awesome-switch(conf-if-eth1/1/48)# fec ?
  CL74-FC     CL74 FEC
  CL91-RS     CL91 FEC
  CL108-RS    CL108 FEC
  CL119-RS    CL119 FEC
  CL134-RS    CL134 FEC
  CL91-RS544  CL91-RS544 FEC
  off         Disable FEC

ISSUE TYPE

• Bug Report

COMPONENT NAME

role: os10_interface

ANSIBLE VERSION

ansible [core 2.15.5]

COLLECTION VERSION

dellemc.os10-1.2.4

CONFIGURATION

-

OS / ENVIRONMENT

Hardware: DELL S5248F-ON
Software version: 10.5.5.8

STEPS TO REPRODUCE

os10_interface:
  ethernet 1/1/48:
    desc: "just a faulty sample port configuration"
    fec: true

WRONG CODE

roles/os10_interface/templates/os10_interface.j2

 {% if intf_vars.fec is defined %}
    {% if intf_vars.fec %}
 fec on
    {% else %}
 fec off
    {% endif %}
 no fec
  {% endif %}

FIXED CODE

roles/os10_interface/templates/os10_interface.j2

  {% if intf_vars.fec is defined %}
    {% if intf_vars.fec %}
 fec {{ intf_vars.fec }}
    {% else %}
 no fec
    {% endif %}
  {% endif %}

Example for correct host_var/group_var code:

os10_interface:
  ethernet 1/1/48:
    desc: "just a correct sample port configuration"
    fec: CL74-FC