Skip to content

Commit a6aa446

Browse files
authored
chore: address cleanup script linter warnings
chore: address cleanup script linter warnings
2 parents 7dcce5e + 0074be1 commit a6aa446

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

scripts/cleanup-project.sh

+4-3
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,13 @@ cleanup_resource() {
4242

4343
if [ -z "$extra_list_arg" ]
4444
then
45-
resources=( $(gcloud "${resource_group}" "${resource}" list --project="${PROJECT_ID}" --format="csv[no-heading](name)") )
45+
mapfile -t resources < <(gcloud "${resource_group}" "${resource}" list --project="${PROJECT_ID}" --format="csv[no-heading](name)")
4646
else
47-
resources=( $(gcloud "${resource_group}" "${resource}" list --project="${PROJECT_ID}" --format="csv[no-heading](name)" "${extra_list_arg}") )
47+
mapfile -t resources < <(gcloud "${resource_group}" "${resource}" list --project="${PROJECT_ID}" --format="csv[no-heading](name)" "${extra_list_arg}")
4848
fi
4949

50-
for resource_id in $resources; do
50+
for resource_id in "${resources[@]}"
51+
do
5152
if [ -z "$extra_delete_arg" ]
5253
then
5354
gcloud "${resource_group}" "${resource}" delete "${resource_id}" --project="${PROJECT_ID}" -q

0 commit comments

Comments
 (0)