Ansible Meta Schema issue

[zx80]

Summary

The Ansible Meta JSON Schema has some issues which means that unintended json are accepted which should be rejected.

Issue Type

• Bug Report

Description

1. On line 485 else must move in one of the [] item above, otherwise without if it is simply ignored:

        }
      ],
      "else": {
        "$comment": "If standalone is false, then we have a collection role and only description is required",
        "required": ["description"]
      },

2. On line 1546 additionalProperties must be moved out of properties, as it is not an intended optional property name for the object:

      "properties": {
        "additionalProperties": false,
        " allow_duplicates": {

3. The semantics of the not required on line 470 is very strange. It seems to mean these properties must not appear together, but any subset is fine, which does not seem to make sense.

4. if on line 443 and 461 should probably add a required on the standalone keyword. As it is written, both conditions matches if standalone is not there.

[alisonlhart]

Hi @zx80, thanks for opening this issue! We would welcome a PR to resolve this.

[zx80]

Hi @zx80, thanks for opening this issue! We would welcome a PR to resolve this.

For points 3 and 4, the schema should depend on what is actually expected, and I do not know that, I can just guess that it is very probably not was is described.

[zx80]

See #4676 for issues 1 and 2.