candidate: network.healthchecks

[Ruchip16]

Candidate Name

network.healthchecks

Link to Github Repo

https://github.com/ansible-network/network.healthchecks

Review Due By

CHECKLIST

Business Checks:

Content Viability

• must support a “business-viable” use case
• isn’t just a demo
• is production-ready, as in able to run in Ansible Controller “as-is”
• provides a solution an end-to-end automation use case and brings value to our customers

Content Duplication

• use case addressed by the content isn’t covered by another validated content collection already - to the best of our knowledge

Technical Checks:

Content Conformity

• is packaged as a content collection - see the Collection Requirements Checklist
• is YAML only (Exception: if plugin(s) included are necessary for this specific use-case and are not generic enough for a certified collection)
• if there is a plugin(s), it is not a duplicate of something from a certified or supported collection - to the best of our knowledge
• supported plugin/module used in a validated role is noted as a dependency

Content Compliance

• no known policy or legal reason for why the content shouldn’t be published
• README contains information about the purpose of the collection and how to install it
• README contains a link to the collection license file
• README contains general usage and requirements information such as required versions of ansible-core and Python, and other required libraries or SDKs
• install / requirements.yml information all points to Automation Hub, not a Github repo
• Repo is self-certified with the OpenSSF Best Practices and has the OpenSSF Best Practices Badge
• Has 2 or more active maintainers listed in a CODEOWNERS file.
• Has an approved OSI license
• Content falls logically into one of these domains - infra, security, network, cloud, edge
• (If internal content) Content has been or is being migrated into the redhat-cop Github org

Content Testing/Validation

• runs ansible-lint “Production” profile in an active Github workflow on the repository
• passes the ansible-lint “Production” profile
• ansible-lint.yml file (if present) only contains justified ignores - with a comment explaining the need for each ignore

[djdanielsson]

there are no GitHub actions for linting or any other tests

[Ruchip16]

hi @djdanielsson the github actions have been added now for linters - PR, can you please give it a final review so that we can proceed with the release for the collection, thanks!

[djdanielsson]

unfortunately there isn't a great way to put random comments to suggest changes outside of PR's. I would move all the folders of templates that are inside the tasks folder to the role folder (layout looks like defaults files handlers meta README.md tasks templates tests vars) which is the standard layout, though some people do remove folders they are not using. I did notice a set_fact that seems hardcoded and I was going to suggest making it a var in the var's section but I am guessing the logic behind that was to prevent anyway of overriding this. I haven't looked at everything else those were just a few things I kinda noticed skimming some of the roles.

[Ruchip16]

Hey, thanks for going through the roles and sharing your observations!
To clarify the set_fact part, I think the one you noticed might be from tasks like this:

- name: Parse bgp summary  
  ansible.utils.cli_parse:  
    command: "show bgp summary"  
    parser:  
      name: ansible.netcommon.content_templates  
    set_fact: bgp_health

This isn’t a hardcoded fact — it’s part of the cli_parse module’s functionality where the parsed output is stored as a fact. So it’s dynamic and comes from the command result, not something statically assigned.

Regarding the templates folder placement, i agree that aligning it with the standard role structure (i.e. templates/ at the root level) makes sense. We’ll take a look into it.

[Ruchip16]

hi @djdanielsson here is the PR: https://github.com/ansible-network/network.healthchecks/pull/11 that plcaes the templates folder same level as others, please take a look and let me know if you have any other feedback, thanks!

[djdanielsson]

I think it looks good now