fix(image-uploader): upload props ts type #6821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
afc163
reviewed
Feb 4, 2025
| @@ -199,7 +199,7 @@ export const ImageUploader = forwardRef<ImageUploaderRef, ImageUploaderProps>( | |||
| await Promise.all( | |||
| newTasks.map(async (currentTask, index) => { | |||
| try { | |||
| const result = await props.upload(currentTask.file) | |||
| const result = await props.upload!(currentTask.file) | |||
There was a problem hiding this comment.
是的，其他情况会，我是看他说的 disableUpload 的情况，onChange 就不会触发。
多加一个这个呢？
if (!props.upload && !props.disableUpload) {
console.error('提示upload必传')
return
}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6821 +/- ##
=======================================
Coverage 92.70% 92.70%
=======================================
Files 335 335
Lines 7199 7199
Branches 1793 1805 +12
=======================================
Hits 6674 6674
Misses 490 490
Partials 35 35 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #6799