Skip to content

Commit 7dcaa5b

Browse files
committed
refactor: enhance type safety in state updater functions
- Updated state updater functions in DigitRange and Money components to explicitly define the type of the previous state. - Modified ProHelpModal to remove unnecessary parameters in the afterClose callback. - Improved type handling in ProTable tests for better clarity and maintainability.
1 parent ab4e829 commit 7dcaa5b

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/field/components/DigitRange/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const FieldDigitRange: ProFieldFC<FieldDigitRangeProps> = (
4848
| undefined
4949
| ((prev: ValuePair | undefined) => ValuePair | undefined),
5050
) => {
51-
setValuePairInner((prev) => {
51+
setValuePairInner((prev: ValuePair | undefined) => {
5252
const next =
5353
typeof updater === 'function'
5454
? (updater as (p: ValuePair | undefined) => ValuePair | undefined)(

src/field/components/Money/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ const InputNumberPopover = React.forwardRef<
237237
);
238238
const onChange = useCallback(
239239
(updater: any | ((prev: any) => any)) => {
240-
setValueInner((prev) => {
240+
setValueInner((prev: any) => {
241241
const next =
242242
typeof updater === 'function'
243243
? (updater as (p: any) => any)(prev)

src/layout/components/Help/ProHelpModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export const ProHelpModal: React.FC<ProHelpModalProps> = ({
3131
typeof updater === 'function'
3232
? (updater as (p: boolean) => boolean)(prev)
3333
: updater;
34-
modalProps?.afterClose?.(next);
34+
modalProps?.afterClose?.();
3535
return next;
3636
});
3737
},

tests/table/protable-editable-onsave-record.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ describe('ProTable editable onSave record', () => {
9797
expect(onSave).toHaveBeenCalledTimes(1);
9898
});
9999

100-
const record = onSave.mock.calls[0][1] as any;
100+
const record = (onSave.mock.calls[0] as unknown as [any, any, any])[1];
101101
expect(Number(record.all_money)).toBe(22);
102102
expect(record).not.toHaveProperty('0');
103103
expect(record).not.toHaveProperty('1');
@@ -127,7 +127,7 @@ describe('ProTable editable onSave record', () => {
127127
expect(onSave).toHaveBeenCalledTimes(1);
128128
});
129129

130-
const record = onSave.mock.calls[0][1] as any;
130+
const record = (onSave.mock.calls[0] as unknown as [any, any, any])[1];
131131
expect(String(record.all_money)).toBe('22');
132132
expect(record).not.toHaveProperty('0');
133133
expect(record).not.toHaveProperty('1');

0 commit comments

Comments
 (0)