Refactored VOD rest method, so that sonar passes cognitive complexity check.

Author: master312

src/main/java/io/antmedia/rest/RestServiceBase.java

@@ -1256,101 +1256,71 @@ public Result uploadVoDFile(String fileName, InputStream inputStream) {
 	}
 
 	public Result uploadVoDFile(String fileName, InputStream inputStream, String metadata) {
-		boolean success = false;
-		String message = "";
-		String id= null;
+		String id = null;
 		String appScopeName = getScope().getName();
 		String fileExtension = FilenameUtils.getExtension(fileName);
-		try {
-
-			String[] supportedFormats = new String[] {"mp4", "webm", "mov", "avi", "mp3", "wmv"};
-
-			if (ArrayUtils.contains(supportedFormats, fileExtension)) {
-
-
-				IStatsCollector statsCollector = (IStatsCollector) getAppContext().getBean(IStatsCollector.BEAN_NAME);
-				String vodUploadFinishScript = getAppSettings().getVodUploadFinishScript();
-				if (StringUtils.isNotBlank(vodUploadFinishScript)  && !statsCollector.enoughResource()) 
-				{
-					logger.info("Not enough resource to upload VoD file");
-					message = "Not enough system resources available to upload and process VoD File";
-				} 
-				else 
-				{
-
-					File streamsDirectory = new File(
-							getStreamsDirectory(appScopeName));
-
-					// if the directory does not exist, create it
-					if (!streamsDirectory.exists()) {
-						streamsDirectory.mkdirs();
-					}
-					String vodId = RandomStringUtils.secure().nextNumeric(24);
-
-
-					File savedFile = new File(streamsDirectory, vodId + "." + fileExtension);
-
-					if (!savedFile.toPath().normalize().startsWith(streamsDirectory.toPath().normalize())) {
-						throw new IOException("Entry is outside of the target directory");
-					} 
-
-					int read = 0;
-					byte[] bytes = new byte[2048];
-					try (OutputStream outpuStream = new FileOutputStream(savedFile))
-					{
-
-						while ((read = inputStream.read(bytes)) != -1) {
-							outpuStream.write(bytes, 0, read);
-						}
-						outpuStream.flush();
-
-						long fileSize = savedFile.length();
-						long unixTime = System.currentTimeMillis();
+		
+		String[] supportedFormats = new String[] {"mp4", "webm", "mov", "avi", "mp3", "wmv"};
+		if (!ArrayUtils.contains(supportedFormats, fileExtension)) {
+			//this message has been used in the frontend(webpanel) pay attention
+			return new Result(false, null, "notSupportedFileType");
+		}
 
-						String path = savedFile.getPath();
+		IStatsCollector statsCollector = (IStatsCollector) getAppContext().getBean(IStatsCollector.BEAN_NAME);
+		String vodUploadFinishScript = getAppSettings().getVodUploadFinishScript();
+		if (StringUtils.isNotBlank(vodUploadFinishScript) && !statsCollector.enoughResource()) {
+			logger.info("Not enough resource to upload VoD file");
+			return new Result(false, null, "Not enough system resources available to upload and process VoD File");
+		}
 
+		try {
+			File streamsDirectory = new File(getStreamsDirectory(appScopeName));
+			if (!streamsDirectory.exists()) {
+				streamsDirectory.mkdirs();
+			}
 
-						String relativePath = AntMediaApplicationAdapter.getRelativePath(path);
+			String vodId = RandomStringUtils.secure().nextNumeric(24);
+			File savedFile = new File(streamsDirectory, vodId + "." + fileExtension);
 
-						VoD newVod = new VoD(fileName, "file", relativePath, fileName, unixTime, 0, Muxer.getDurationInMs(savedFile,fileName), fileSize,
-								VoD.UPLOADED_VOD, vodId, null);
+			if (!savedFile.toPath().normalize().startsWith(streamsDirectory.toPath().normalize())) {
+				throw new IOException("Entry is outside of the target directory");
+			}
 
-						if (StringUtils.isNotBlank(metadata)) {
-							newVod.setMetadata(metadata);
-						}
+			int read = 0;
+			byte[] bytes = new byte[2048];
+			try (OutputStream outpuStream = new FileOutputStream(savedFile)) {
+				while ((read = inputStream.read(bytes)) != -1) {
+					outpuStream.write(bytes, 0, read);
+				}
+				outpuStream.flush();
 
-						if (StringUtils.isNotBlank(vodUploadFinishScript)) {
-							newVod.setProcessStatus(VoD.PROCESS_STATUS_INQUEUE);
-						}
+				long fileSize = savedFile.length();
+				long unixTime = System.currentTimeMillis();
+				String relativePath = AntMediaApplicationAdapter.getRelativePath(savedFile.getPath());
 
-						id = getDataStore().addVod(newVod);
+				VoD newVod = new VoD(fileName, "file", relativePath, fileName, unixTime, 0, 
+						Muxer.getDurationInMs(savedFile, fileName), fileSize, VoD.UPLOADED_VOD, vodId, null);
 
-						if(id != null) {
-							success = true;
-							message = id;
+				if (StringUtils.isNotBlank(metadata)) {
+					newVod.setMetadata(metadata);
+				}
 
-							if (StringUtils.isNotBlank(vodUploadFinishScript)) 
-							{
-								startVoDScriptProcess(vodUploadFinishScript, savedFile, newVod, id);	
+				if (StringUtils.isNotBlank(vodUploadFinishScript)) {
+					newVod.setProcessStatus(VoD.PROCESS_STATUS_INQUEUE);
+				}
 
-							}
+				id = getDataStore().addVod(newVod);
 
-						}
-					}
+				if (id != null && StringUtils.isNotBlank(vodUploadFinishScript)) {
+					startVoDScriptProcess(vodUploadFinishScript, savedFile, newVod, id);
 				}
 			}
-			else {
-				//this message has been used in the frontend(webpanel) pay attention
-				message = "notSupportedFileType";
-			}
-
-		}
-		catch (IOException iox) {
+		} catch (IOException iox) {
 			logger.error(iox.getMessage());
+			return new Result(false, null, "");
 		}
 
-
-		return new Result(success, id, message);
+		return new Result(id != null, id, id != null ? id : "");
 	}
 
 	public void startVoDScriptProcess(String vodUploadFinishScript, File savedFile, VoD newVod, String vodId) {