Add Channels creates duplicate channel id's

[markcs]

Summary

When trying to create a channel with a curl POST command, I am getting channels with duplicate channel ids.

curl -d "@channel.json" -X POST 'https://<server ip>/api/channels'
{"id":338,"sessionUrl":null,"headers":[],"group":null,"playlist":null,"playlistName":null,"playlistUpdate":false}

and then, for this example:

curl -s 'https://<server ip>/api/channels/' | jq | grep 338
    "id": 338,
    "id": 338,

Two channels with id 338 are created. This causes the frontend not to load.

I am also not able to create a channel successfully using the following json template. Is this correct?

  {
    "name": "channel name (mandatory)",
    "url": "channel url (mandatory)",
    "sessionUrl": null,
    "avatar": "channel avatar url (optional)",
    "mode": "one of direct/proxy/restream",
    "headers": [],
    "group": null,
    "playlist": null,
    "playlistName": null,
    "playlistUpdate": true or false

  }

[antebrl]

Thank you for reporting.

I am also not able to create a channel successfully using the following json template. Is this correct?

Your json seems correct, I tried with this:

{
    "name": "test",
    "url": "https://test.com",
    "sessionUrl": null,
    "avatar": "https://test.com",
    "mode": "restream",
    "headers": [],
    "group": null,
    "playlist": null,
    "playlistName": null,
    "playlistUpdate": true
}

It worked fine. Make sure to make the request correct.

POST /api/channels with the json as body

---

I'm not able to get duplicate channel ids by using this POST endpoint. Could you please further eloborate.

Be aware that as this endpoint is not used by the frontend, which adds channel through websocket connection, and therefore is not checked for any wrong values like your input:
{"id":338,"sessionUrl":null,"headers":[],"group":null,"playlist":null,"playlistName":null,"playlistUpdate":false}

For now use the correct format. I'll rewrite the web-endpoints when migrating to a database setup (which could also fix the duplicate id problem).

[markcs]

I had already created channels by importing a playlist through the web frontend and then tried to create new channels using the api. Could that be causing the duplicate ids?

I tried your test json above and using the following curl command, but am still getting empty channels created and all I see in the backend is "Data saved successfully."

curl -d "@test.json" -X POST <server url>
{"id":341,"sessionUrl":null,"headers":[],"group":null,"playlist":null,"playlistName":null,"playlistUpdate":false}

  {
    "id": 339,
    "sessionUrl": null,
    "headers": [],
    "group": null,
    "playlist": null,
    "playlistName": null,
    "playlistUpdate": false
  },
  {
    "id": 340,
    "sessionUrl": null,
    "headers": [],
    "group": null,
    "playlist": null,
    "playlistName": null,
    "playlistUpdate": false
  },
  {
    "id": 341,
    "sessionUrl": null,
    "headers": [],
    "group": null,
    "playlist": null,
    "playlistName": null,
    "playlistUpdate": false
  }

Assuming I get this working, can the json file contain more than one channel? ie if I export out the channel list, can I import it again if I rebuild the container?

[antebrl]

Assuming I get this working, can the json file contain more than one channel? ie if I export out the channel list, can I import it again if I rebuild the container?

At the moment this is not supported. You should make a m3u playlist and import this one again after you cleared all channels.
Still a good idea for the future, thank you

I tried your test json above and using the following curl command, but am still getting empty channels

It worked for me, so check if you are up to date with the main branch. Maybe clear all channels before and see if it works then. Also send me the exact test.json and endpoint you are trying to use with curl. I'll try if the command works for me.

[markcs]

I tried with your json above and my exact comment is:
curl -d "@test.json" -X POST http://192.168.1.254/api/channels
I'm using Caddy as my reverse proxy, so wonder if that is causing issues? I am not using nginx at all, but all other features appear to work. ie I can delete the channels I add using the API.

[antebrl]

Ok, I found the issue. You need to set the Content-Type header. Postman did this automatically for me, that's why it worked for me.
curl -H "Content-Type: application/json" -d "@test.json" -X POST http://192.168.1.254/api/channels

It's a somewhat bad response if you don't set it. I should fix this in the future.

[markcs]

That works. Thanks