Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has anyone got Whammy to work recently? #71

Open
pkallerm opened this issue Apr 30, 2022 · 2 comments
Open

Has anyone got Whammy to work recently? #71

pkallerm opened this issue Apr 30, 2022 · 2 comments

Comments

@pkallerm
Copy link

Hi,

I see there's basically two issues it seems like with Whammy as a result of the passage of time -- (1) a modification to the webp code and (2) something with CreateObjectUrl (I think this has been superceded).

Has anyone successfully modified to work recently? If so, would you be open to sharing your updated .js?

Thank you,

Philip

@isagues
Copy link

isagues commented Sep 2, 2022

From what i've seen there are problems with the different WebP encodings.

Whammy works for files encode with VP8 (Lossy). Currently in Firefox 104.0.1 canvas are converted to VP8 and whammy works. However, when trying to process VP8X or VP8L (Lossless) it fails.

The VP8X problem can be solved with #70 (comment). Which removes the extra file headers. Resulting in VP8 or VP8L data.

In any case you end up with VP8L data (could be via VP8X) whammy will fail.

var frame_start = VP8.indexOf('\x9d\x01\x2a'); //A VP8 keyframe starts with the 0x9d012a header

This pattern won't be present and

@RafaelSencare
Copy link

I simply cannot make it work with VP8X, even with the fixes mentioned on @isagues comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants