Remove redundant countries prefix on config keys
#182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicated list currencies
[ci skip] [skip ci]
Apply fixes from StyleCI [ci skip] [skip ci]
[ci skip] [skip ci]
Apply fixes from StyleCI [ci skip] [skip ci]
[ci skip] [skip ci]
Apply fixes from StyleCI [ci skip] [skip ci]
[ci skip] [skip ci]
Apply fixes from StyleCI [ci skip] [skip ci]
Update README.md
Update composer dependencies
[ci skip] [skip ci]
…Dggv Apply fixes from StyleCI [ci skip] [skip ci]
test against php 7.4 - remove prefix 'snapshot'
Fix README issues
`currency` should be pluralized to `currencies` as
```
->hydrate('currency')
```
and
```
->currency
```
aren't things.
Currency should be plural
[ci skip] [skip ci]
…RgYP Apply fixes from StyleCI [ci skip] [skip ci]
Fix flag-icon
…nd Nette classes with will effectively read from `countries.countries.cache.enabled`.
Author
|
The original code does not seem to be formatted to match the StyleCI settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using https://github.com/antonioribeiro/countries-laravel, there is no way to enable or disable caching by overwriting the
countries.phpconfig. I found that this is due to redundantcountries.prefixes in the Cache Service and Nette classes which lead to effectively reading fromcountries.countries.cache.enabled, thus ignoring any settings for cache.enabled.This is reproducible by publishing the config and changing any of the cache settings, for example the temp directory. All of the settings will be ignored, because the request to
countries.countries.cache.enabledwill return null, which is cast to false when returned from the Cache'senabled()method.This PR will remove the redundant
countriesprefixes and will presumably also fix antonioribeiro/countries-laravel#17.