Merge pull request mislav#2656 from cuonglm/master

mislav · web-flow · commit df284079043b · 2020-12-01T20:10:43.000+01:00
github: fix unbuffered channel passed to signal.Notify
diff --git a/github/config.go b/github/config.go
@@ -198,7 +198,7 @@ func getPassword() (string, error) {
 		return "", err
 	}
 
-	c := make(chan os.Signal)
+	c := make(chan os.Signal, 1)
 	signal.Notify(c, os.Interrupt, syscall.SIGTERM)
 	go func() {
 		s := <-c

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ func getPassword() (string, error) {`
`198`	`198`	`return "", err`
`199`	`199`	`}`
`200`	`200`
`201`		`- c := make(chan os.Signal)`
	`201`	`+ c := make(chan os.Signal, 1)`
`202`	`202`	`signal.Notify(c, os.Interrupt, syscall.SIGTERM)`
`203`	`203`	`go func() {`
`204`	`204`	`s := <-c`