-
Notifications
You must be signed in to change notification settings - Fork 1.8k
docs: selection and virtual render site demo #4850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @GaoFuhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求主要通过引入两个新的站点演示来增强文档内容。这些演示分别展示了多节点虚拟渲染和框选批量拖拽多节点的功能,旨在为用户提供更直观的实践案例,帮助他们更好地理解和利用相关特性,从而提升图表交互的性能和用户体验。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
您好,这次的 Pull Request 添加了两个关于虚拟渲染和框选拖拽的站点示例,代码清晰地展示了 X6 的相关功能。我主要针对 TypeScript 代码的类型定义、代码冗余和语法正确性提出了一些改进建议,希望能帮助提升代码质量和可维护性。具体细节请参考文件中的评论。
| }), | ||
| ) | ||
|
|
||
| const nodes: any[] = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| graph.use(new Scroller({ enabled: true, pannable: true })) | ||
|
|
||
| const nodes: any[] = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
虚拟渲染:


批量拖拽:
Motivation and Context
Types of changes
Self Check before Merge