-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept password hash in config #135
Comments
I must say that placing even hashed passwords in the public doesn't seem like a great idea. |
A password that's hashed with bcrypt with enough rounds is fine to be published, afaik. My usecase is the following; we're creating a NixOS configuration and I'd like wayvnc to be available by just enabling one config option. Currently, we take in one password hash for a user, and then just apply that hash everywhere appropriate. https://git.b12f.io/pub-solar/os/src/commit/e10f27785498a10cfc22de8c89f76defa98c4599/users/ben/default.nix#L22 |
If someone decides to implement this, please use a strong hashing algorithm by today's standards. |
another solution to this problem would be reading the password from a separate secret file, which can be managed using sops-nix or equivalent. |
Having a file for the password seems like an OK feature. I won't say no to it if it's correctly done. |
It'd be great if the config file would accept password hashes, so the config can be put in a public repository without compromising the secret.
The text was updated successfully, but these errors were encountered: