Skip to content

Commit ea97db8

Browse files
committed
optimize the code. avoid doing eigendecomposition twice
1 parent 372c976 commit ea97db8

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

HippsDimes.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -348,9 +348,7 @@ def __init__(self, ddmap_target, connectivity_matrix=None):
348348
self.loss = None
349349

350350

351-
def __compute_loss(self):
352-
ddmap_t = ((3. * np.pi) / 8.) * \
353-
np.power(a2dmap_theory(self.A, force_positive_definite=True), 2.)
351+
def __compute_loss(self, ddmap_t):
354352
with np.errstate(divide='ignore', invalid='ignore'):
355353
loss = np.nanmean(
356354
np.power((ddmap_t - self.ddmap_target)/self.ddmap_target, 2.)) ** .5
@@ -418,7 +416,7 @@ def __update_parameter(self, t, learning_rate, lamd=0.0, reg='l2', method='IS',
418416
#self.A = nearestNSD(self.A, 0.0)
419417

420418
# compute the loss
421-
self.loss = self.__compute_loss()
419+
self.loss = self.__compute_loss(ddmap_t)
422420

423421
def run(self, epoch, general_method='optimization', **kwargs):
424422
"""

0 commit comments

Comments
 (0)