ci: integrate alembic check

Author: guan404ming

.pre-commit-config.yaml

@@ -1387,4 +1387,11 @@ repos:
         require_serial: true
         pass_filenames: false
         files: ^airflow-core/src/airflow/config_templates/config\.yml$
+      - id: check-model-changes
+        name: Check if model changes require DB migration
+        entry: ./scripts/ci/pre_commit/check_model_changes.py
+        language: python
+        additional_dependencies: ['rich>=12.4.4']
+        files: ^airflow-core/src/airflow/models/.*\.py$
+        require_serial: true
         ## ONLY ADD PRE-COMMITS HERE THAT REQUIRE CI IMAGE

contributing-docs/08_static_code_checks.rst

@@ -197,6 +197,8 @@ require Breeze Docker image to be built locally.
 +-----------------------------------------------------------+--------------------------------------------------------+---------+
 | check-min-python-version                                  | Check minimum Python version                           |         |
 +-----------------------------------------------------------+--------------------------------------------------------+---------+
+| check-model-changes                                       | Check if model changes require DB migration            | *       |
++-----------------------------------------------------------+--------------------------------------------------------+---------+
 | check-newsfragments-are-valid                             | Check newsfragments are valid                          |         |
 +-----------------------------------------------------------+--------------------------------------------------------+---------+
 | check-no-airflow-deprecation-in-providers                 | Do not use DeprecationWarning in providers             |         |

dev/breeze/doc/images/output_static-checks.svg

@@ -1 +1 @@
-651b0a909a13812254e531ed04ff609c
+4e41a38d69485a6c2a3c4022e241aeba

dev/breeze/doc/images/output_static-checks.txt

@@ -62,6 +62,7 @@
     "check-links-to-example-dags-do-not-use-hardcoded-versions",
     "check-merge-conflict",
     "check-min-python-version",
+    "check-model-changes",
     "check-newsfragments-are-valid",
     "check-no-airflow-deprecation-in-providers",
     "check-no-providers-in-core-examples",

dev/breeze/src/airflow_breeze/pre_commit_ids.py

@@ -0,0 +1,46 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+import sys
+from pathlib import Path
+
+sys.path.insert(0, str(Path(__file__).parent.resolve()))
+from common_precommit_utils import (
+    initialize_breeze_precommit,
+    run_command_via_breeze_shell,
+    validate_cmd_result,
+)
+
+initialize_breeze_precommit(__name__, __file__)
+result = run_command_via_breeze_shell(
+    [
+        "bash",
+        "-c",
+        "cd airflow-core/src/airflow && alembic check",
+    ],
+    backend="sqlite",
+    warn_image_upgrade_needed=True,
+    skip_environment_initialization=False,
+    extra_env={
+        "DB_RESET": "true",
+    },
+)
+
+validate_cmd_result(result, include_ci_env_check=True)