Skip to content

Commit 200bd62

Browse files
[v2-10-test] Fix update issues for object and advanced-arrays fields when empty default (#45313) (#45315)
(cherry picked from commit 6eab1f2) Co-authored-by: Jens Scheffler <[email protected]>
1 parent c1f4131 commit 200bd62

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

airflow/www/static/js/trigger.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@ function updateJSONconf() {
5959
}
6060
}
6161
params[keyName] = values.length === 0 ? null : values;
62-
} else if (elements[i].value.length === 0) {
63-
params[keyName] = null;
6462
} else if (
6563
elements[i].attributes.valuetype &&
6664
(elements[i].attributes.valuetype.value === "object" ||
@@ -81,6 +79,8 @@ function updateJSONconf() {
8179
// ignore JSON parsing errors
8280
// we don't want to bother users during entry, error will be displayed before submit
8381
}
82+
} else if (elements[i].value.length === 0) {
83+
params[keyName] = null;
8484
} else if (Number.isNaN(elements[i].value)) {
8585
params[keyName] = elements[i].value;
8686
} else if (

airflow/www/templates/airflow/trigger.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,9 @@
120120
{% elif form_details.schema and "object" in form_details.schema.type %}
121121
<textarea class="form-control" name="element_{{ form_key }}" id="element_{{ form_key }}" valuetype="object" rows="6"
122122
{%- if not "null" in form_details.schema.type %} required=""{% endif -%}>
123-
{{- form_details.value | tojson() -}}
123+
{%- if form_details.value %}
124+
{{- form_details.value | tojson() -}}
125+
{% endif -%}
124126
</textarea>
125127
{% elif form_details.schema and ("integer" in form_details.schema.type or "number" in form_details.schema.type) %}
126128
<input class="form-control" name="element_{{ form_key }}" id="element_{{ form_key }}"

0 commit comments

Comments
 (0)