Skip to content

Commit 3c63bb6

Browse files
insomnesRNHTTR
andauthored
Fix kubernetes executor watcher kube_client_request_args shadowing (#45528)
* Fix watcher kube_client_request_args shadowing * Update providers/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py Apply suggestion by review Co-authored-by: Ryan Hatter <[email protected]> --------- Co-authored-by: Ryan Hatter <[email protected]>
1 parent 05fe5a4 commit 3c63bb6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

providers/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,10 @@ def _run(
147147
# For info about k8s timeout settings see
148148
# https://github.com/kubernetes-client/python/blob/v29.0.0/examples/watch/timeout-settings.md
149149
# and https://github.com/kubernetes-client/python/blob/v29.0.0/kubernetes/client/api_client.py#L336-L339
150-
client_timeout = 30
151-
server_conn_timeout = 3600
152-
kwargs["_request_timeout"] = client_timeout
153-
kwargs["timeout_seconds"] = server_conn_timeout
150+
if "_request_timeout" not in kwargs:
151+
kwargs["_request_timeout"] = 30
152+
if "timeout_seconds" not in kwargs:
153+
kwargs["timeout_seconds"] = 3600
154154

155155
logical_date_key = get_logical_date_key()
156156
for event in self._pod_events(kube_client=kube_client, query_kwargs=kwargs):

0 commit comments

Comments
 (0)