Skip to content

Commit a242e21

Browse files
author
Guangyang Li
committed
fix test_secutiry.py
1 parent ebd1609 commit a242e21

File tree

2 files changed

+24
-6
lines changed

2 files changed

+24
-6
lines changed

providers/cncf/kubernetes/tests/unit/cncf/kubernetes/operators/test_pod.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@ def temp_override_attr(obj, attr, val):
9595
def clear_db():
9696
db.clear_db_dags()
9797
db.clear_db_runs()
98-
db.clear_db_dag_bundles()
98+
if AIRFLOW_V_3_0_PLUS:
99+
db.clear_db_dag_bundles()
99100

100101

101102
def create_context(task, persist_to_db=False, map_index=None):

providers/fab/tests/unit/fab/auth_manager/test_security.py

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,19 @@ def _delete_dag_permissions(dag_id, security_manager):
129129
security_manager.delete_permission(dag_action_name, dag_resource_name)
130130

131131

132-
def _create_dag_model(dag_id, session, security_manager):
133-
bundle_name = "test_bundle"
132+
def _create_dag_bundle(bundle_name, session):
134133
bundle = DagBundleModel(name=bundle_name)
135134
session.add(bundle)
136-
session.flush()
135+
session.commit()
136+
return bundle
137+
138+
139+
def _delete_dag_bundle(bundle_name, session):
140+
session.query(DagBundleModel).filter(DagBundleModel.name == bundle_name).delete()
141+
session.commit()
142+
143+
144+
def _create_dag_model(dag_id, bundle_name, session, security_manager):
137145
dag_model = DagModel(dag_id=dag_id, bundle_name=bundle_name)
138146
session.add(dag_model)
139147
session.commit()
@@ -173,9 +181,12 @@ def _has_all_dags_access(user) -> bool:
173181

174182
@contextlib.contextmanager
175183
def _create_dag_model_context(dag_id, session, security_manager):
176-
dag = _create_dag_model(dag_id, session, security_manager)
184+
bundle_name = "test_bundle"
185+
_create_dag_bundle(bundle_name, session)
186+
dag = _create_dag_model(dag_id, bundle_name, session, security_manager)
177187
yield dag
178188
_delete_dag_model(dag, session, security_manager)
189+
_delete_dag_bundle(bundle_name, session)
179190

180191

181192
@pytest.fixture(scope="module", autouse=True)
@@ -242,12 +253,15 @@ def role(request, app, security_manager):
242253
@pytest.fixture
243254
def mock_dag_models(request, session, security_manager):
244255
dags_ids = request.param
245-
dags = [_create_dag_model(dag_id, session, security_manager) for dag_id in dags_ids]
256+
bundle_name = "test_bundle"
257+
_create_dag_bundle(bundle_name, session)
258+
dags = [_create_dag_model(dag_id, bundle_name, session, security_manager) for dag_id in dags_ids]
246259

247260
yield dags_ids
248261

249262
for dag in dags:
250263
_delete_dag_model(dag, session, security_manager)
264+
_delete_dag_bundle(bundle_name, session)
251265

252266

253267
@pytest.fixture
@@ -1066,7 +1080,10 @@ def test_permissions_work_for_dags_with_dot_in_dagname(
10661080
security_manager.sync_perm_for_dag(dag2.dag_id, access_control={role_name: READ_WRITE})
10671081
assert_user_has_dag_perms(perms=["GET", "PUT"], dag_id=dag_id, user=user)
10681082
assert_user_does_not_have_dag_perms(perms=["GET", "PUT"], dag_id=dag_id_2, user=user)
1083+
# Clean up DAG models and bundle
10691084
session.query(DagModel).delete()
1085+
session.query(DagBundleModel).filter(DagBundleModel.name == bundle_name).delete()
1086+
session.commit()
10701087

10711088

10721089
@pytest.fixture

0 commit comments

Comments
 (0)