You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Along with a small change to bash operator, i added another task to the example bash operator dag.
But I have found that this example dag is used in many tests. These tests do not examine the behavior of bash operator -- they just use it because it is there. But since they make assumptions about the exact number and ordering of tasks in this dag, any change to the example dag breaks them.
I think example dags should just be examples and not used in tests. What do you think?
Question
Any suggestions about a new home -- i.e. which folder -- for "test" dags?
Thoughts on migration
As to how we might migrate this... I am not sure it needs to be all or nothing. That is, I could just copy the existing bash operator example to new home unchanged. Then update tests to point to the "test" dag. Then I can freely add my task to the "example" dag, without worrying about any impact on tests that have nothing to do with my change.
Update
Ok looks like this use of example bash operator is more exception than rule and there are tests dags in tests/dags
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Overview
Along with a small change to bash operator, i added another task to the example bash operator dag.
But I have found that this example dag is used in many tests. These tests do not examine the behavior of bash operator -- they just use it because it is there. But since they make assumptions about the exact number and ordering of tasks in this dag, any change to the example dag breaks them.
I think example dags should just be examples and not used in tests. What do you think?
Question
Any suggestions about a new home -- i.e. which folder -- for "test" dags?
Thoughts on migration
As to how we might migrate this... I am not sure it needs to be all or nothing. That is, I could just copy the existing bash operator example to new home unchanged. Then update tests to point to the "test" dag. Then I can freely add my task to the "example" dag, without worrying about any impact on tests that have nothing to do with my change.
Update
Ok looks like this use of example bash operator is more exception than rule and there are tests dags in
tests/dags
Will try to copy it there
Beta Was this translation helpful? Give feedback.
All reactions