[MAINTENANCE] Simplify triple negation usage

Author: alien11689

blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/ext/AbstractPropertyPlaceholderExt.java

@@ -204,7 +204,7 @@ protected Metadata processServiceMetadata(ServiceMetadata component) {
         }
 
         List<MapEntry> entries = new ArrayList<MapEntry>(component.getServiceProperties());
-        if(!!! entries.isEmpty()) {
+        if(! entries.isEmpty()) {
 
             try {
                 if(component instanceof MutableServiceMetadata) {
@@ -284,7 +284,7 @@ private Metadata processServiceReferenceMetadata(ServiceReferenceMetadata compon
     protected Metadata processPropsMetadata(PropsMetadata metadata) {
 
         List<MapEntry> entries = new ArrayList<MapEntry>(metadata.getEntries());
-        if(!!! entries.isEmpty()) {
+        if(! entries.isEmpty()) {
 
             try {
                 if(metadata instanceof MutablePropsMetadata) {
@@ -311,7 +311,7 @@ protected Metadata processPropsMetadata(PropsMetadata metadata) {
 
     protected Metadata processMapMetadata(MapMetadata metadata) {
         List<MapEntry> entries = new ArrayList<MapEntry>(metadata.getEntries());
-        if(!!! entries.isEmpty()) {
+        if(! entries.isEmpty()) {
 
             try {
                 if(metadata instanceof MutableMapMetadata) {
@@ -359,7 +359,7 @@ protected List<MapEntry> processMapEntries(List<MapEntry> entries) {
     protected Metadata processCollectionMetadata(CollectionMetadata metadata) {
 
         List<Metadata> values = new ArrayList<Metadata>(metadata.getValues());
-        if(!!! values.isEmpty()) {
+        if(! values.isEmpty()) {
 
             try {
                 if(metadata instanceof MutableCollectionMetadata) {

blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/utils/ReflectionUtils.java

@@ -292,7 +292,7 @@ public static PropertyDescriptor[] getPropertyDescriptors(Class clazz, boolean a
             if (allowFieldInjection) {
                 for (Class cl = clazz; cl != null && cl != Object.class; cl = cl.getSuperclass()) {
                     for (Field field : cl.getDeclaredFields()) {
-                        if (!!!Modifier.isStatic(field.getModifiers())) {
+                        if (!Modifier.isStatic(field.getModifiers())) {
                             String name = decapitalize(field.getName());
                             PropertyDescriptor desc = props.get(name);
                             if (desc == null) {
@@ -311,7 +311,7 @@ public static PropertyDescriptor[] getPropertyDescriptors(Class clazz, boolean a
 
             List<PropertyDescriptor> result = new ArrayList<PropertyDescriptor>();
             for (PropertyDescriptor prop : props.values()) {
-                if (!!!illegalProperties.contains(prop.getName())) result.add(prop);
+                if (!illegalProperties.contains(prop.getName())) result.add(prop);
             }
 
             properties[index] = result.toArray(new PropertyDescriptor[result.size()]); 
@@ -536,7 +536,7 @@ public Boolean run() throws Exception {
                       return Boolean.FALSE;
                     }                        
                 });
-                if(!!!wasSet) {
+                if(!wasSet) {
                   doInternalSet(container, instance, value);
                 }
             } catch (PrivilegedActionException pae) {

blueprint/blueprint-noosgi/src/main/java/org/apache/aries/blueprint/ext/AbstractPropertyPlaceholder.java

@@ -198,7 +198,7 @@ protected Metadata processBeanMetadata(BeanMetadata component) {
     protected Metadata processPropsMetadata(PropsMetadata metadata) {
 
         List<MapEntry> entries = new ArrayList<MapEntry>(metadata.getEntries());
-        if(!!! entries.isEmpty()) {
+        if(! entries.isEmpty()) {
 
             try {
                 if(metadata instanceof MutablePropsMetadata) {
@@ -225,7 +225,7 @@ protected Metadata processPropsMetadata(PropsMetadata metadata) {
 
     protected Metadata processMapMetadata(MapMetadata metadata) {
         List<MapEntry> entries = new ArrayList<MapEntry>(metadata.getEntries());
-        if(!!! entries.isEmpty()) {
+        if(! entries.isEmpty()) {
 
             try {
                 if(metadata instanceof MutableMapMetadata) {
@@ -273,7 +273,7 @@ protected List<MapEntry> processMapEntries(List<MapEntry> entries) {
     protected Metadata processCollectionMetadata(CollectionMetadata metadata) {
 
         List<Metadata> values = new ArrayList<Metadata>(metadata.getValues());
-        if(!!! values.isEmpty()) {
+        if(! values.isEmpty()) {
 
             try {
                 if(metadata instanceof MutableCollectionMetadata) {

jmx/jmx-core-whiteboard/src/main/java/org/apache/aries/jmx/core/whiteboard/Activator.java

@@ -220,7 +220,7 @@ private <T> void registerMBean(String type, Factory<T> factory, String objectNam
     synchronized (result) {
       ServiceRegistration reg = registerAnMbean(type, factory, objectName);
 
-      if (!!!result.compareAndSet(null, reg)) {
+      if (!result.compareAndSet(null, reg)) {
         reg.unregister();
       }
     }

jndi/jndi-core/src/main/java/org/apache/aries/jndi/startup/Activator.java

@@ -231,7 +231,7 @@ private boolean isPropertyEnabled(BundleContext context, String key) {
         if (null != value) return true;
         Object revision = context.getBundle().adapt(BundleRevision.class);
         // in a unit test adapt() may return an incompatible object
-        if (!!! (revision instanceof BundleRevision)) return false;
+        if (! (revision instanceof BundleRevision)) return false;
         final BundleRevision bundleRevision = (BundleRevision) revision;
         return bundleRevision.getDeclaredCapabilities(key).size() > 0;
     }

proxy/proxy-impl/src/main/java/org/apache/aries/proxy/impl/AbstractProxyManager.java

@@ -153,7 +153,7 @@ private Object duplicateProxy(Collection<Class<?>> classes, Callable<Object> dis
 
       classToProxy = classes.iterator().next();
 
-      if(!!!isProxyClass(classToProxy))
+      if(!isProxyClass(classToProxy))
         classToProxy = null;
     }
 

proxy/proxy-impl/src/main/java/org/apache/aries/proxy/impl/AsmProxyManager.java

@@ -64,7 +64,7 @@ public Object createNewProxy(Bundle clientBundle, Collection<Class<?>> classes,
     Set<Class<?>> interfaces = new HashSet<Class<?>>();
 
     for (Class<?> clazz : classes) {
-      if (!!!clazz.isInterface()) {
+      if (!clazz.isInterface()) {
         notInterfaces.add(clazz);
       } else {
         interfaces.add(clazz);
@@ -224,7 +224,7 @@ private Class<?> getLowestSubclass(Set<Class<?>> notInterfaces) throws
         //potential can be widened to classToProxy, and is therefore
         //a lower subclass
         classToProxy = potential;
-      } else if (!!!potential.isAssignableFrom(classToProxy)){
+      } else if (!potential.isAssignableFrom(classToProxy)){
         //classToProxy is not a subclass of potential - This is
         //an error, we can't be part of two hierarchies at once!
         throw new UnableToProxyException(classToProxy, "The requested classes "
@@ -242,7 +242,7 @@ private boolean isConcrete(Class<?> classToProxy) {
   private boolean implementsAll(Class<?> classToProxy, Set<Class<?>> interfaces) {
     //If we can't widen to one of the interfaces then we need to do some more work
     for(Class<?> iface : interfaces) {
-      if(!!!iface.isAssignableFrom(classToProxy))
+      if(!iface.isAssignableFrom(classToProxy))
         return false;
     }
     return true;

proxy/proxy-impl/src/main/java/org/apache/aries/proxy/impl/JdkProxyManager.java

@@ -39,7 +39,7 @@ public Object createNewProxy(Bundle clientBundle, Collection<Class<?>> classes,
   private static final Class<?>[] getInterfaces(Collection<Class<?>> classes) throws UnableToProxyException
   {
     for (Class<?> clazz : classes) {
-        if (!!!clazz.isInterface()) {
+        if (!clazz.isInterface()) {
           throw new UnableToProxyException(clazz, String.format("The class %s is not an interface and therefore a proxy cannot be generated.", clazz.getName()));
         } 
     }

proxy/proxy-impl/src/main/java/org/apache/aries/proxy/impl/common/MethodCopyingClassAdapter.java

@@ -98,14 +98,14 @@ public final MethodVisitor visitMethod(final int access, String name, String des
     MethodVisitor mv = null;
     //As in WovenProxyAdapter, we only care about "real" methods, but also not
     //abstract ones!.
-    if (!!!name.equals("<init>") && !!!name.equals("<clinit>")
+    if (!name.equals("<init>") && !name.equals("<clinit>")
         && (access & (ACC_STATIC | ACC_PRIVATE | ACC_SYNTHETIC | ACC_ABSTRACT
             | ACC_NATIVE | ACC_BRIDGE)) == 0) {
 
       // identify the target method parameters and return type
       Method currentTransformMethod = new Method(name, desc);
       // We don't want to duplicate a method we already overrode! 
-      if(!!!knownMethods.add(currentTransformMethod))
+      if(!knownMethods.add(currentTransformMethod))
         return null;
 
       // found a method we should weave
@@ -116,7 +116,7 @@ public final MethodVisitor visitMethod(final int access, String name, String des
       // We can't call up to a default access method if we aren't in the same
       // package
       if((access & (ACC_PUBLIC | ACC_PROTECTED | ACC_PRIVATE)) == 0) {
-        if(!!!samePackage) {
+        if(!samePackage) {
             methodHiddenException(name);
         }
       }

proxy/proxy-impl/src/main/java/org/apache/aries/proxy/impl/common/OSGiFriendlyClassWriter.java

@@ -85,7 +85,7 @@ protected final String getCommonSuperClass(String arg0, String arg1) {
                 return OBJECT_INTERNAL_NAME; //arg0 is an interface
               }
               aRunning = false; //old arg00 was java.lang.Object
-            } else if(!!!names.add(arg00)) {
+            } else if(!names.add(arg00)) {
               return arg00;
             }
           } else {
@@ -104,7 +104,7 @@ protected final String getCommonSuperClass(String arg0, String arg1) {
                 return OBJECT_INTERNAL_NAME;  //arg1 is an interface
               }
               bRunning = false; //old arg11 was java.lang.Object
-            } else if(!!!names.add(arg11)) {
+            } else if(!names.add(arg11)) {
               return arg11;
             }
           } else {