refactor(arrow/array): replace some codegen with generics (#315)

### Rationale for this change
Simplifying code and removing old code-gen

### What changes are included in this PR?
Replacing the old `numeric.gen.go` and `numeric.gen.go.tmpl` with a new
version built using go generics.

### Are these changes tested?
All the same unit tests will test the new versions of the objects

### Are there any user-facing changes?
There shouldn't be any user-facing changes. Everything was designed to
avoid any public breaking changes.

Author: zeroshade

arrow/array.go

@@ -127,3 +127,15 @@ type Array interface {
 	// When the reference count goes to zero, the memory is freed.
 	Release()
 }
+
+// ValueType is a generic constraint for valid Arrow primitive types
+type ValueType interface {
+	bool | FixedWidthType | string | []byte
+}
+
+// TypedArray is an interface representing an Array of a particular type
+// allowing for easy propagation of generics
+type TypedArray[T ValueType] interface {
+	Array
+	Value(int) T
+}

arrow/array/binary.go

@@ -450,4 +450,8 @@ var (
 
 	_ BinaryLike = (*Binary)(nil)
 	_ BinaryLike = (*LargeBinary)(nil)
+
+	_ arrow.TypedArray[[]byte] = (*Binary)(nil)
+	_ arrow.TypedArray[[]byte] = (*LargeBinary)(nil)
+	_ arrow.TypedArray[[]byte] = (*BinaryView)(nil)
 )

arrow/array/boolean.go

@@ -122,5 +122,6 @@ func arrayEqualBoolean(left, right *Boolean) bool {
 }
 
 var (
-	_ arrow.Array = (*Boolean)(nil)
+	_ arrow.Array            = (*Boolean)(nil)
+	_ arrow.TypedArray[bool] = (*Boolean)(nil)
 )

arrow/array/compare.go

@@ -240,37 +240,37 @@ func Equal(left, right arrow.Array) bool {
 		return arrayEqualStringView(l, r)
 	case *Int8:
 		r := right.(*Int8)
-		return arrayEqualInt8(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Int16:
 		r := right.(*Int16)
-		return arrayEqualInt16(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Int32:
 		r := right.(*Int32)
-		return arrayEqualInt32(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Int64:
 		r := right.(*Int64)
-		return arrayEqualInt64(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Uint8:
 		r := right.(*Uint8)
-		return arrayEqualUint8(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Uint16:
 		r := right.(*Uint16)
-		return arrayEqualUint16(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Uint32:
 		r := right.(*Uint32)
-		return arrayEqualUint32(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Uint64:
 		r := right.(*Uint64)
-		return arrayEqualUint64(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Float16:
 		r := right.(*Float16)
-		return arrayEqualFloat16(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Float32:
 		r := right.(*Float32)
-		return arrayEqualFloat32(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Float64:
 		r := right.(*Float64)
-		return arrayEqualFloat64(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Decimal32:
 		r := right.(*Decimal32)
 		return arrayEqualDecimal(l, r)
@@ -285,16 +285,16 @@ func Equal(left, right arrow.Array) bool {
 		return arrayEqualDecimal(l, r)
 	case *Date32:
 		r := right.(*Date32)
-		return arrayEqualDate32(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Date64:
 		r := right.(*Date64)
-		return arrayEqualDate64(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Time32:
 		r := right.(*Time32)
-		return arrayEqualTime32(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Time64:
 		r := right.(*Time64)
-		return arrayEqualTime64(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Timestamp:
 		r := right.(*Timestamp)
 		return arrayEqualTimestamp(l, r)
@@ -327,7 +327,7 @@ func Equal(left, right arrow.Array) bool {
 		return arrayEqualMonthDayNanoInterval(l, r)
 	case *Duration:
 		r := right.(*Duration)
-		return arrayEqualDuration(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Map:
 		r := right.(*Map)
 		return arrayEqualMap(l, r)
@@ -502,28 +502,28 @@ func arrayApproxEqual(left, right arrow.Array, opt equalOption) bool {
 		return arrayApproxEqualStringView(l, r)
 	case *Int8:
 		r := right.(*Int8)
-		return arrayEqualInt8(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Int16:
 		r := right.(*Int16)
-		return arrayEqualInt16(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Int32:
 		r := right.(*Int32)
-		return arrayEqualInt32(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Int64:
 		r := right.(*Int64)
-		return arrayEqualInt64(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Uint8:
 		r := right.(*Uint8)
-		return arrayEqualUint8(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Uint16:
 		r := right.(*Uint16)
-		return arrayEqualUint16(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Uint32:
 		r := right.(*Uint32)
-		return arrayEqualUint32(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Uint64:
 		r := right.(*Uint64)
-		return arrayEqualUint64(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Float16:
 		r := right.(*Float16)
 		return arrayApproxEqualFloat16(l, r, opt)
@@ -547,16 +547,16 @@ func arrayApproxEqual(left, right arrow.Array, opt equalOption) bool {
 		return arrayEqualDecimal(l, r)
 	case *Date32:
 		r := right.(*Date32)
-		return arrayEqualDate32(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Date64:
 		r := right.(*Date64)
-		return arrayEqualDate64(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Time32:
 		r := right.(*Time32)
-		return arrayEqualTime32(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Time64:
 		r := right.(*Time64)
-		return arrayEqualTime64(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Timestamp:
 		r := right.(*Timestamp)
 		return arrayEqualTimestamp(l, r)
@@ -589,7 +589,7 @@ func arrayApproxEqual(left, right arrow.Array, opt equalOption) bool {
 		return arrayEqualMonthDayNanoInterval(l, r)
 	case *Duration:
 		r := right.(*Duration)
-		return arrayEqualDuration(l, r)
+		return arrayEqualFixedWidth(l, r)
 	case *Map:
 		r := right.(*Map)
 		if opt.unorderedMapKeys {

arrow/array/decimal.go

@@ -429,4 +429,9 @@ var (
 	_ Builder     = (*Decimal64Builder)(nil)
 	_ Builder     = (*Decimal128Builder)(nil)
 	_ Builder     = (*Decimal256Builder)(nil)
+
+	_ arrow.TypedArray[decimal.Decimal32]  = (*Decimal32)(nil)
+	_ arrow.TypedArray[decimal.Decimal64]  = (*Decimal64)(nil)
+	_ arrow.TypedArray[decimal.Decimal128] = (*Decimal128)(nil)
+	_ arrow.TypedArray[decimal.Decimal256] = (*Decimal256)(nil)
 )

arrow/array/float16.go

@@ -119,5 +119,6 @@ func arrayEqualFloat16(left, right *Float16) bool {
 }
 
 var (
-	_ arrow.Array = (*Float16)(nil)
+	_ arrow.Array                   = (*Float16)(nil)
+	_ arrow.TypedArray[float16.Num] = (*Float16)(nil)
 )

arrow/array/interval.go

@@ -950,4 +950,8 @@ var (
 	_ Builder = (*MonthIntervalBuilder)(nil)
 	_ Builder = (*DayTimeIntervalBuilder)(nil)
 	_ Builder = (*MonthDayNanoIntervalBuilder)(nil)
+
+	_ arrow.TypedArray[arrow.MonthInterval]        = (*MonthInterval)(nil)
+	_ arrow.TypedArray[arrow.DayTimeInterval]      = (*DayTimeInterval)(nil)
+	_ arrow.TypedArray[arrow.MonthDayNanoInterval] = (*MonthDayNanoInterval)(nil)
 )