Skip to content

Commit c1890d4

Browse files
committed
Update old inaccurate comments about test coverage
1 parent 8de2775 commit c1890d4

File tree

1 file changed

+5
-15
lines changed

1 file changed

+5
-15
lines changed

arrow-flight/src/encode.rs

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -681,10 +681,6 @@ mod tests {
681681

682682
use super::*;
683683

684-
// TESTS TO ADD:
685-
// - Ensure ArrayData::get_slice_memory_size_with_alignment returns the same data size as IPC
686-
// encoding it
687-
688684
#[test]
689685
// flight_data_from_arrow_batch is deprecated but does exactly what we need. Would probably be
690686
// good to just move it to this test mod when it's due to be removed.
@@ -1684,17 +1680,11 @@ mod tests {
16841680

16851681
/// Coverage for <https://github.com/apache/arrow-rs/issues/3478>
16861682
///
1687-
/// Encodes the specified batch using several values of
1688-
/// `max_flight_data_size` between 1K to 5K and ensures that the
1689-
/// resulting size of the flight data stays within the limit
1690-
/// + `allowed_overage`
1691-
///
1692-
/// `allowed_overage` is how far off the actual data encoding is
1693-
/// from the target limit that was set. It is an improvement when
1694-
/// the allowed_overage decreses.
1695-
///
1696-
/// Note this overhead will likely always be greater than zero to
1697-
/// account for encoding overhead such as IPC headers and padding.
1683+
/// Encodes the specified batch using several values of `max_flight_data_size` between 1K to 5K
1684+
/// and ensures that the resulting size of the flight data stays within the limit, except for
1685+
/// in cases where only 1 row is sent - if only 1 row is sent, then we know that there was no
1686+
/// way to keep the data within the limit (since the minimum possible amount of data was sent),
1687+
/// so we allow it to go over.
16981688
///
16991689
async fn verify_encoded_split_no_overage(batch: RecordBatch) {
17001690
let num_rows = batch.num_rows();

0 commit comments

Comments
 (0)