-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC] Support bitwise op in arrow-rs #2702
Comments
I think moving these kernels to arrow is a great idea -- thank you @liukun4515 -- and likely the experts in arrow-rs will be able to offer some suggestions on how to improve the performance |
When I implement the left/right shift operation for the bitwise, I meet an issue. In the rust, the operation Can we add a new trait like |
The issue you've linked relates to const versions of the functions, looking at the docs wrapping_shl seems to be defined for all the primitive types - e.g. https://doc.rust-lang.org/stable/std/primitive.i64.html#method.wrapping_shl |
But the My point is the api of https://doc.rust-lang.org/stable/src/core/num/wrapping.rs.html#87. Do you means that we can implement all data type with converting the |
Tbh I'm not sure I fully understand the use-case for left or right shifting based on anything but a scalar, what does C++ do? |
I think the biggest argument in my mind is for completeness -- I can cook up some examples when one might use it but they would definitely be contrived. |
I don't have any thoughts or opinions on the shift implementation -- I defer to @tustvold |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
from the issue about bitwise op in the datafusion, we should migration the bitwise op to the arrow-rs
Describe the solution you'd like
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: