Skip to content

Looking for help maintaining (reviewing PRs) in arrow/parquet/object_store #6418

Closed
@alamb

Description

@alamb

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

PRs in this repository are now taking days/weeks to review, which results in

  1. Slower velocity (how fast we can change this library)
  2. A bad community experience (if you get no feedback for a while, it is likely you will go elsewhere to help)

This repo isn't something "we" are providing or are gate keeping. This is project is a community effort in all aspects.

Describe the solution you'd like
I would like more capacity to review PRs in this repo so that we can merge them faster and accelerate progress in this repository.

Reviewing PRs means;

  1. Ensure all PRs are looked at in a timely manner (ideally within 24 hours) (see list here)
  2. Ensure the PR follow the contribution guidelines.
  3. Ensure the PR is clearly documented, and the code follows existing patterns
  4. Ensure the new functionality is covered with tests
  5. When it looks good, @ mention one of the committers and we'll give it a review and merge

Describe alternatives you've considered
I would like everyone who contributes code to this repository to feel both welcome and empowered to review PRs. It takes time and effort, no doubt, but you will very likely learn something and sustained help reviewing PRs is a great way to be considered for committer yourself.

If you are waiting on a review, please consider helping review other PRs -- it will reduce the time before your PR is reviewed.

People may have the idea that PRs can only be reviewed by "committers" in arrow. However, this is not the case -- committers need to do a final approve + merge, but anyone can (and should!) be reviewing other PRs.

As an example, @iffyio's work in sqlparser-rs is textbook example of how to review PRs: https://github.com/sqlparser-rs/sqlparser-rs/pulls?q=is%3Apr+commenter%3Aiffyio

Additional context
Previously @tustvold spent a significant amount of his effort on reviewing PRs in this crate and was paid to do so by InfluxData. He has now moved on to other endeavors, and while he is still helping and InfluxData is working on backfilling his review capacity this project should not be seen as something we can afford to maintain by ourselves

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementAny new improvement worthy of a entry in the changelog

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions