Skip to content

Commit 8dca469

Browse files
committed
Use ARROW_DCHECK_GE/ARROW_DCHECK_GT instead of DCHECK_GE/DCHECK_GT to fix build after merge
1 parent d642d90 commit 8dca469

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

cpp/src/arrow/array/builder_run_end.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
#include "arrow/scalar.h"
2727
#include "arrow/util/checked_cast.h"
2828
#include "arrow/util/int_util_overflow.h"
29-
#include "arrow/util/logging_internal.h"
29+
#include "arrow/util/logging.h"
3030
#include "arrow/util/ree_util.h"
3131

3232
namespace arrow {
@@ -58,7 +58,7 @@ Status RunCompressorBuilder::AppendNulls(int64_t length) {
5858
}
5959
if (ARROW_PREDICT_FALSE(current_run_length_ == 0)) {
6060
// Open a new NULL run
61-
DCHECK_EQ(current_value_, NULLPTR);
61+
ARROW_DCHECK_EQ(current_value_, NULLPTR);
6262
current_run_length_ = length;
6363
} else if (current_value_ == NULLPTR) {
6464
// Extend the currently open NULL run
@@ -129,7 +129,7 @@ Status RunCompressorBuilder::AppendScalars(const ScalarVector& scalars) {
129129

130130
Status RunCompressorBuilder::AppendRunCompressedArraySlice(
131131
const ArraySpan& run_compressed_array, int64_t offset, int64_t length) {
132-
DCHECK(!has_open_run());
132+
ARROW_DCHECK(!has_open_run());
133133
RETURN_NOT_OK(inner_builder_->AppendArraySlice(run_compressed_array, offset, length));
134134
UpdateDimensions();
135135
return Status::OK();
@@ -197,7 +197,7 @@ Status RunEndEncodedBuilder::AppendNulls(int64_t length) {
197197

198198
Status RunEndEncodedBuilder::AppendEmptyValues(int64_t length) {
199199
RETURN_NOT_OK(value_run_builder_->AppendEmptyValues(length));
200-
DCHECK_EQ(value_run_builder_->open_run_length(), 0);
200+
ARROW_DCHECK_EQ(value_run_builder_->open_run_length(), 0);
201201
UpdateDimensions(committed_logical_length_, 0);
202202
return Status::OK();
203203
}
@@ -222,8 +222,8 @@ template <typename RunEndCType>
222222
Status RunEndEncodedBuilder::DoAppendArraySlice(const ArraySpan& array, int64_t offset,
223223
int64_t length) {
224224
ARROW_DCHECK(offset + length <= array.length);
225-
DCHECK_GT(length, 0);
226-
DCHECK(!value_run_builder_->has_open_run());
225+
ARROW_DCHECK_GT(length, 0);
226+
ARROW_DCHECK(!value_run_builder_->has_open_run());
227227

228228
ree_util::RunEndEncodedArraySpan<RunEndCType> ree_span(array, array.offset + offset,
229229
length);

cpp/src/arrow/util/rle_encoding_internal.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ inline bool RleDecoder::Get(T* val) {
309309

310310
template <typename T>
311311
inline bool RleDecoder::GetNextRun(T* val, int* num_repeats, int batch_size) {
312-
DCHECK_GE(bit_width_, 0);
312+
ARROW_DCHECK_GE(bit_width_, 0);
313313
int values_read = 0;
314314

315315
while (values_read == 0) {
@@ -338,15 +338,15 @@ template <typename T>
338338
inline bool RleDecoder::GetNextRunSpaced(T* val, bool* is_null, int* num_repeats,
339339
int batch_size, const uint8_t* valid_bits,
340340
int64_t valid_bits_offset) {
341-
DCHECK_GE(bit_width_, 0);
341+
ARROW_DCHECK_GE(bit_width_, 0);
342342
arrow::internal::BitRunReader bit_reader(valid_bits, valid_bits_offset,
343343
/*length=*/batch_size);
344344
arrow::internal::BitRun valid_run = bit_reader.NextRun();
345345
while (ARROW_PREDICT_FALSE(valid_run.length == 0)) {
346346
valid_run = bit_reader.NextRun();
347347
}
348-
DCHECK_GT(batch_size, 0);
349-
DCHECK_GT(valid_run.length, 0);
348+
ARROW_DCHECK_GT(batch_size, 0);
349+
ARROW_DCHECK_GT(valid_run.length, 0);
350350
if (valid_run.set) {
351351
return GetNextRun(
352352
val, num_repeats,

cpp/src/parquet/column_reader.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
#include "arrow/array/builder_binary.h"
3535
#include "arrow/array/builder_dict.h"
3636
#include "arrow/array/builder_primitive.h"
37+
#include "arrow/array/builder_run_end.h"
3738
#include "arrow/chunked_array.h"
3839
#include "arrow/type.h"
3940
#include "arrow/util/bit_stream_utils_internal.h"

0 commit comments

Comments
 (0)