apply suggestions

Author: mapleFU

cpp/src/parquet/arrow/arrow_parquet_index_test.cc

@@ -101,7 +101,7 @@ using parquet::schema::GroupNode;
 using parquet::schema::NodePtr;
 using parquet::schema::PrimitiveNode;
 
-namespace arrow::parquet {
+namespace parquet::arrow {
 
 namespace {
 
@@ -748,4 +748,4 @@ TEST_F(ParquetBloomFilterRoundTripTest, ThrowForBoolean) {
               ::testing::HasSubstr("BloomFilterBuilder does not support boolean type"));
 }
 
-}  // namespace arrow::parquet
+}  // namespace parquet::arrow

cpp/src/parquet/bloom_filter_builder_internal.h

@@ -22,7 +22,7 @@
 
 namespace parquet {
 
-/// @brief Interface for collecting bloom filter of a parquet file.
+/// @brief Interface for building bloom filters of a parquet file.
 class PARQUET_EXPORT BloomFilterBuilder {
  public:
   /// @brief API to create a BloomFilterBuilder.

cpp/src/parquet/bloom_filter_writer_internal.cc

@@ -100,7 +100,11 @@ void BloomFilterWriterImpl<ParquetType>::UpdateBloomFilterSpaced(
 template <>
 void BloomFilterWriterImpl<BooleanType>::UpdateBloomFilterSpaced(const bool*, int64_t,
                                                                  const uint8_t*,
-                                                                 int64_t) {}
+                                                                 int64_t) {
+  if (ARROW_PREDICT_FALSE(bloom_filter_ != nullptr)) {
+    throw ParquetException("BooleanType does not support bloom filters");
+  }
+}
 
 template <>
 void BloomFilterWriterImpl<FLBAType>::UpdateBloomFilterSpaced(const FLBA* values,

cpp/src/parquet/bloom_filter_writer_internal.h

@@ -18,15 +18,12 @@
 #pragma once
 
 #include "parquet/bloom_filter.h"
+#include "parquet/type_fwd.h"
 
 namespace arrow {
 class Array;
 }
 
-namespace parquet {
-class ColumnDescriptor;
-}
-
 namespace parquet::internal {
 
 template <typename ParquetType>
@@ -41,6 +38,7 @@ class PARQUET_EXPORT BloomFilterWriterImpl {
                                const uint8_t* valid_bits, int64_t valid_bits_offset);
   void UpdateBloomFilterArray(const ::arrow::Array& values);
 
+  /// @brief Check if this writer has enabled bloom filter.
   bool HasBloomFilter() const;
 
  private:

cpp/src/parquet/properties.h

@@ -242,9 +242,9 @@ class PARQUET_EXPORT ColumnProperties {
 
   void set_bloom_filter_options(std::optional<BloomFilterOptions> bloom_filter_options) {
     if (bloom_filter_options) {
-      if (bloom_filter_options->fpp > 1.0 || bloom_filter_options->fpp < 0.0) {
+      if (bloom_filter_options->fpp >= 1.0 || bloom_filter_options->fpp <= 0.0) {
         throw ParquetException(
-            "Bloom filter false-positive probability must fall in [0.0, 1.0], got " +
+            "Bloom filter false-positive probability must fall in (0.0, 1.0), got " +
             std::to_string(bloom_filter_options->fpp));
       }
     }
@@ -705,7 +705,7 @@ class PARQUET_EXPORT WriterProperties {
     /// Disable bloom filter for the column specified by `path`.
     /// Default disabled.
     Builder* disable_bloom_filter(const std::string& path) {
-      bloom_filter_options_[path] = std::nullopt;
+      bloom_filter_options_.erase(path);
       return this;
     }